login-add-eks-cluster-support #1102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvix
commented
Aug 10, 2023
calvix
commented
Aug 10, 2023
calvix
commented
Aug 10, 2023
|
Pinged bigmac as the owners of the login command |
anvddriesch
reviewed
Aug 16, 2023
| if r.loginOptions.isWCClientCert { | ||
| return r.handleWCClientCert(ctx) | ||
| if r.loginOptions.isWC { | ||
| err := r.handleWCKubeconfig(ctx) |
There was a problem hiding this comment.
Same here, the function being called is specifically for handling client certs on a workload cluster. (We are planning to move this to a different command so it'll be helpful to keep the name)
There was a problem hiding this comment.
the function for handling clientcert is still there it just moved later to avoid code duplication
https://github.com/giantswarm/kubectl-gs/pull/1102/files#diff-1f160945410f9311805f9b1ff5284e4cbb59cdd8934057db5bd7b3e40049979fR199-R271
|
Added few comments as we agreed in the call. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
towards giantswarm/roadmap#2609
add
opsctl loginsupport for EKS WCas EKS only supports kubeconfigs with aws cli IAM auth, its necessary to have active and working AWS credentials in order to use the kubeconfig, there is no proper workaround