Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove node classes from vsphere cluster template #1499

Merged
merged 3 commits into from
Nov 26, 2024
Merged

Conversation

anvddriesch
Copy link
Contributor

@anvddriesch anvddriesch commented Nov 26, 2024

https://github.com/giantswarm/giantswarm/issues/31984

What does this PR do?

(Please set a descriptive PR title. Use this space for additional explanations.)

What is the effect of this change to users?

What does it look like?

(Please add anything that represents the change visually. Screenshots, output, logs, ...)

Any background context you can provide?

(Please link public issues or summarize if not public.)

What is needed from the reviewers?

Do the docs need to be updated?

Should this change be mentioned in the release notes?

  • CHANGELOG.md has been updated

Is this a breaking change?

(Breaking changes are, for example, removal of commands/flags or substantial changes in the meaning of a flag. If yes, please add the breaking-change label to the PR.)

@anvddriesch anvddriesch requested a review from a team November 26, 2024 07:57
@anvddriesch anvddriesch self-assigned this Nov 26, 2024
@anvddriesch anvddriesch requested a review from a team as a code owner November 26, 2024 07:57
@anvddriesch anvddriesch enabled auto-merge (squash) November 26, 2024 10:15
@anvddriesch anvddriesch merged commit 868a7c9 into main Nov 26, 2024
2 checks passed
@anvddriesch anvddriesch deleted the remove-nodeclasses branch November 26, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants