Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Customization of the template #10

Merged
merged 13 commits into from
Apr 3, 2024

Conversation

suarezgpablo
Copy link
Contributor

Summary of changes:
-Updated the pom files of the main project, the two modules and the bom.
-Updated the README with the Gitlab's repository version.
-Updated the names of the modules and the bom.

@suarezgpablo suarezgpablo linked an issue Apr 1, 2024 that may be closed by this pull request
@michaelmior
Copy link

michaelmior commented Apr 2, 2024

I think upgrading to Java 9 may resolve the issue.

@suarezgpablo
Copy link
Contributor Author

@javiertuya It seems that now it does not accept Java version 17. I searched on Google and I found this:

https://mkyong.com/maven/maven-error-invalid-target-release-17/

It might be caused by the version of Maven.

@michaelmior
Copy link

michaelmior commented Apr 2, 2024

@suarezgpablo Upgrading to Java 9 seems to work fine in my fork. Although if you need Java 17 for some other reason, that doesn't help. If you do need to specify the Maven version, I would suggest using Maven Wrapper.

@javiertuya
Copy link
Contributor

@suarezgpablo Check the workflow files, they are still in java 8

@javiertuya
Copy link
Contributor

@suarezgpablo This is the setup you are using:
image

@suarezgpablo
Copy link
Contributor Author

@suarezgpablo Upgrading to Java 9 seems to work fine in my fork. Although if you need Java 17 for some other reason, that doesn't help. If you do need to specify the Maven version, I would suggest using Maven Wrapper.

There is a dependency of MoDEvo that will need at least Java 17 to work. Nevertheless, I think the problem is related to the workflow, which I didn't notice to update the Java version. I will try it now with the updated workflow Java version

Copy link
Contributor

@javiertuya javiertuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are still parts that need customization. I mentioned some of them in the comments, but there are others like .classpath files (that are still using java 1.8)

.gitignore Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
pom.xml Show resolved Hide resolved
modevo-bom/pom.xml Outdated Show resolved Hide resolved
@suarezgpablo suarezgpablo requested a review from javiertuya April 3, 2024 17:26
.gitignore Outdated Show resolved Hide resolved
@suarezgpablo suarezgpablo requested a review from javiertuya April 3, 2024 18:13
@javiertuya javiertuya merged commit 75096d1 into main Apr 3, 2024
7 checks passed
@javiertuya javiertuya deleted the 5-migration-stage-1-customize-template branch April 3, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration stage 1 - customize template
3 participants