-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Customization of the template #10
Conversation
I think upgrading to Java 9 may resolve the issue. |
@javiertuya It seems that now it does not accept Java version 17. I searched on Google and I found this: https://mkyong.com/maven/maven-error-invalid-target-release-17/ It might be caused by the version of Maven. |
@suarezgpablo Upgrading to Java 9 seems to work fine in my fork. Although if you need Java 17 for some other reason, that doesn't help. If you do need to specify the Maven version, I would suggest using Maven Wrapper. |
@suarezgpablo Check the workflow files, they are still in java 8 |
@suarezgpablo This is the setup you are using: |
There is a dependency of MoDEvo that will need at least Java 17 to work. Nevertheless, I think the problem is related to the workflow, which I didn't notice to update the Java version. I will try it now with the updated workflow Java version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are still parts that need customization. I mentioned some of them in the comments, but there are others like .classpath files (that are still using java 1.8)
Summary of changes:
-Updated the pom files of the main project, the two modules and the bom.
-Updated the README with the Gitlab's repository version.
-Updated the names of the modules and the bom.