Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQLTest healthcheck update to align with msqlserver:CU28-2019 #105

Conversation

augustocristian
Copy link
Contributor

@augustocristian augustocristian commented Aug 18, 2024

This PR closes #104.
A recently cumulative update of msqlserver (sqldata container) broke up all the Dependabot updates in our CI system. We have changed the directory of the sqlcmd binary. Once updated, I've realized of some concurrency problems between our test cases, so I applied the same strategy than Fullteaching test suite.
The changes are:

  • We have changed the location of sqlcmd binary to the newer ones
  • We have changed the test output directories (one for each TJob)
  • We have changed the background tasks dependencies to dont start and not saturate with requests the msql container
  • Solved some flakiness due to timeouts of order-state changes

@augustocristian augustocristian linked an issue Aug 18, 2024 that may be closed by this pull request
@augustocristian augustocristian force-pushed the 104-msql-container-update-broke-the-continuous-integration-pipeline branch from 9ff3472 to e7c36a6 Compare August 18, 2024 20:13
@javiertuya
Copy link
Contributor

@augustocristian I ran this twice, the second one failed

@javiertuya javiertuya removed their request for review August 19, 2024 16:34
@augustocristian augustocristian force-pushed the 104-msql-container-update-broke-the-continuous-integration-pipeline branch 3 times, most recently from 5c82cf2 to f3a291f Compare August 20, 2024 13:27
@augustocristian augustocristian force-pushed the 104-msql-container-update-broke-the-continuous-integration-pipeline branch from f3a291f to 68638b8 Compare August 20, 2024 13:30
@augustocristian
Copy link
Contributor Author

I've executed 15 times since the new dependency of the two services, and no failure appear. I've also solved the flakiness related to the order change (I don't think that in the most elegant way)

@javiertuya javiertuya merged commit 8b80837 into main Aug 21, 2024
2 checks passed
@javiertuya javiertuya deleted the 104-msql-container-update-broke-the-continuous-integration-pipeline branch August 21, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MSQL container update broke the continuous integration pipeline
2 participants