Dealing with zombie processes

giis-uniovi · Aug 16, 2024 · 4a9b015 · 4a9b015
1 parent 585d403
commit 4a9b015
Show file tree

Hide file tree

Showing 19 changed files with 269 additions and 283 deletions.
diff --git a/src/test/java/com/fullteaching/e2e/no_elastest/common/BaseLoggedTest.java b/src/test/java/com/fullteaching/e2e/no_elastest/common/BaseLoggedTest.java
@@ -20,6 +20,8 @@
 
 import java.io.FileInputStream;
 import java.io.IOException;
+import java.net.MalformedURLException;
+import java.net.URISyntaxException;
 import java.util.Date;
 import java.util.List;
 import java.util.Properties;
@@ -48,7 +50,7 @@ public class BaseLoggedTest {
     protected final static int DEPTH = 3;
 
     public WebDriver driver;
-    protected BrowserUser teacher;
+    protected BrowserUser user;
     protected BrowserUser student;
     protected List<BrowserUser> studentBrowserUserList;
 
@@ -107,18 +109,18 @@ static void setupAll() { // 28 lines
     }
 
     @BeforeEach
-    void setup(TestInfo info) { //65 lines
+    void setup(TestInfo info) throws URISyntaxException, MalformedURLException { //65 lines
         log.info("##### Start test: {}" , info.getTestMethod().get().getName());
         TJOB_NAME = System.getProperty("dirtarget");
 
-        teacher = setupBrowser("chrome", TJOB_NAME + "_" + info.getTestMethod().get().getName(), "Teacher", WAIT_SECONDS);
+        this.user = setupBrowser("chrome", TJOB_NAME + "_" + info.getTestMethod().get().getName(), "Teacher", WAIT_SECONDS);
 
-        driver = teacher.getDriver();
+        this.driver = this.user.getDriver();
 
     }
 
     protected BrowserUser setupBrowser(String browser, String testName,
-                                       String userIdentifier, int secondsOfWait) {
+                                       String userIdentifier, int secondsOfWait) throws URISyntaxException, MalformedURLException {
         BrowserUser u;
         log.info("Starting browser ({})", browser);
 
@@ -158,18 +160,18 @@ protected BrowserUser setupBrowser(String browser, String testName,
 
     @AfterEach
     void tearDown(TestInfo info) { //13 lines
-        if (this.teacher != null) {
-            log.info("##### Finish test: {} - Driver {}", info.getTestMethod().get().getName(), this.teacher.getDriver());
+        if (this.user != null) {
+            log.info("##### Finish test: {} - Driver {}", info.getTestMethod().get().getName(), this.user.getDriver());
             log.info("Browser console at the end of the test");
-            LogEntries logEntries = teacher.getDriver().manage().logs().get(BROWSER);
+            LogEntries logEntries = user.getDriver().manage().logs().get(BROWSER);
             logEntries.forEach(entry -> log.info("[{}] {} {}",
                     new Date(entry.getTimestamp()), entry.getLevel(),
                     entry.getMessage()));
-            if (this.teacher.isOnSession()) {
-                this.logout(this.teacher);
+            if (this.user.isOnSession()) {
+                this.logout(this.user);
             }
 
-            this.teacher.dispose();
+            this.user.dispose();
         }
 
         if (this.student != null) {
@@ -179,7 +181,6 @@ void tearDown(TestInfo info) { //13 lines
             logEntries.forEach(entry -> log.info("[{}] {} {}",
                     new Date(entry.getTimestamp()), entry.getLevel(),
                     entry.getMessage()));
-            //TO-DO- ERROR with the logout
             if (this.student.isOnSession()) {
                 this.logout(student);
             }
@@ -243,8 +244,11 @@ private void login(BrowserUser user, String userEmail, String userPass,
         try {
             userName = getUserName(user, true, APP_URL);
         } catch (NotLoggedException | ElementNotFoundException e) {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
+            if (e.getClass().isInstance(NotLoggedException.class)){
+            log.error("The user {} was not logged",user.getClientData());}
+            else{
+                log.error("The userName field not found" );
+            }
         }
 
         log.info("Logging in successful for user {}", user.getClientData());
@@ -327,7 +331,7 @@ protected void openDialog(String cssSelector, BrowserUser user) {
                         "//div[contains(@class, 'modal-overlay') and contains(@style, 'opacity: 0.5')]")),
                 "Dialog not opened");
 
-        log.info("Dialog opened for user {}", user.getClientData());
+        log.info("Dialog opened using css selector for user {}", user.getClientData());
     }
 
     protected void openDialog(WebElement el, BrowserUser user) {//8lines
@@ -339,7 +343,7 @@ protected void openDialog(WebElement el, BrowserUser user) {//8lines
         user.waitUntil(ExpectedConditions.presenceOfElementLocated(By.xpath(
                         "//div[contains(@class, 'modal-overlay') and contains(@style, 'opacity: 0.5')]")),
                 "Dialog not opened");
-        log.info("Dialog opened for user {}", user.getClientData());
+        log.info("Dialog  using webelement for user {}", user.getClientData());
     }
 
     protected void waitForDialogClosed(String dialogId, String errorMessage,

diff --git a/src/test/java/com/fullteaching/e2e/no_elastest/common/BrowserUser.java b/src/test/java/com/fullteaching/e2e/no_elastest/common/BrowserUser.java
@@ -26,8 +26,6 @@
 
 import java.time.Duration;
 
-import static java.lang.invoke.MethodHandles.lookup;
-import static org.slf4j.LoggerFactory.getLogger;
 
 public class BrowserUser {
 

diff --git a/src/test/java/com/fullteaching/e2e/no_elastest/common/ChromeUser.java b/src/test/java/com/fullteaching/e2e/no_elastest/common/ChromeUser.java
@@ -25,7 +25,8 @@
 import org.openqa.selenium.support.ui.WebDriverWait;
 
 import java.net.MalformedURLException;
-import java.net.URL;
+import java.net.URI;
+import java.net.URISyntaxException;
 import java.text.SimpleDateFormat;
 import java.time.Duration;
 import java.time.LocalDateTime;
@@ -41,7 +42,7 @@
 public class ChromeUser extends BrowserUser {
     ChromeOptions options = new ChromeOptions();
 
-    public ChromeUser(String userName, int timeOfWaitInSeconds, String testName, String userIdentifier) {
+    public ChromeUser(String userName, int timeOfWaitInSeconds, String testName, String userIdentifier) throws URISyntaxException, MalformedURLException {
         super(userName, timeOfWaitInSeconds);
         log.info("Starting the configuration of the web browser");
         log.debug(String.format("The Test name is: %s", testName));
@@ -51,15 +52,9 @@ public ChromeUser(String userName, int timeOfWaitInSeconds, String testName, Str
         options.setCapability("goog:loggingPrefs", logPrefs);
 
         //Problems with the max attempt of retry, solved with : https://github.com/aerokube/selenoid/issues/1124 solved with --disable-gpu
+        // options.addArguments("--disable-gpu"); Commented for the moment
         //Problems with flakiness due to screen resolution solved with --start-maximized
-        String[] arguments = {"--start-maximized"};
-
-        log.debug("Adding the arguments ({})", Arrays.toString(arguments));
-        for (String argument : arguments
-        ) {
-            options.addArguments(argument);
-        }
-
+        options.addArguments("--start-maximized");
         options.setAcceptInsecureCerts(true);
         //This capability is to store the logs of the test case
         log.debug("Added Capabilities of acceptInsecureCerts and ignore alarms");
@@ -68,8 +63,6 @@ public ChromeUser(String userName, int timeOfWaitInSeconds, String testName, Str
             log.info("Using the Local WebDriver ()");
             this.driver = new ChromeDriver(options);
         } else {
-            try {
-
                 Map<String, Object> selenoidOptions = new HashMap<>();
                 log.info("Using the remote WebDriver (Selenoid)");
                 SimpleDateFormat format = new SimpleDateFormat("yyyy-MM-dd_HH:mm");
@@ -85,7 +78,7 @@ public ChromeUser(String userName, int timeOfWaitInSeconds, String testName, Str
                 LocalDateTime now = LocalDateTime.now();
                 String logName = System.getProperty("tjob_name") + "-" + dtf.format(now) + "-" + testName + "-" + userIdentifier + ".log";
                 String videoName = System.getProperty("tjob_name") + "-" + dtf.format(now) + "-" + testName + "-" + userIdentifier + ".mp4";
-                log.debug("The data of this test would be stored into: video name " + videoName + " and the log is " + logName);
+                log.debug("The data of this test would be stored into: video name: {} and the log name: {} " , videoName,logName);
 
                 selenoidOptions.put("enableLog", true);
                 selenoidOptions.put("logName ", logName);
@@ -97,13 +90,10 @@ public ChromeUser(String userName, int timeOfWaitInSeconds, String testName, Str
 
                 //END CAPABILITIES FOR SELENOID RETORCH
                 log.debug("Configuring the remote WebDriver ");
-                RemoteWebDriver remote = new RemoteWebDriver(new URL("http://selenoid:4444/wd/hub"), options);
+                RemoteWebDriver remote = new RemoteWebDriver(new URI("http://selenoid:4444/wd/hub").toURL(), options);
                 log.debug("Configuring the Local File Detector");
                 remote.setFileDetector(new LocalFileDetector());
                 this.driver = remote;
-            } catch (MalformedURLException e) {
-                throw new RuntimeException("Exception creating eusApiURL", e);
-            }
         }
         log.debug("Configure the driver connection timeouts at ({})", this.timeOfWaitInSeconds);
         new WebDriverWait(driver, Duration.ofSeconds(this.timeOfWaitInSeconds));

diff --git a/src/test/java/com/fullteaching/e2e/no_elastest/common/EdgeUser.java b/src/test/java/com/fullteaching/e2e/no_elastest/common/EdgeUser.java
@@ -24,7 +24,8 @@
 import org.openqa.selenium.support.ui.WebDriverWait;
 
 import java.net.MalformedURLException;
-import java.net.URL;
+import java.net.URI;
+import java.net.URISyntaxException;
 import java.text.SimpleDateFormat;
 import java.time.Duration;
 import java.time.LocalDateTime;
@@ -36,7 +37,7 @@
 public class EdgeUser extends BrowserUser {
     EdgeOptions options = new EdgeOptions();
 
-    public EdgeUser(String userName, int timeOfWaitInSeconds, String testName, String userIdentifier) {
+    public EdgeUser(String userName, int timeOfWaitInSeconds, String testName, String userIdentifier) throws URISyntaxException {
         super(userName, timeOfWaitInSeconds);
         log.info(String.format("The Test names are: %s", testName));
 
@@ -67,7 +68,7 @@ public EdgeUser(String userName, int timeOfWaitInSeconds, String testName, Strin
                 LocalDateTime now = LocalDateTime.now();
                 String logName = dtf.format(now) + "-" + testName + "-" + userIdentifier + ".log";
                 String videoName = dtf.format(now) + "_" + testName + "_" + userIdentifier + ".mp4";
-                log.debug("The data of this test would be stored into: video name " + videoName + " and the log is " + logName);
+                log.debug("The data of this test would be stored into: video name {} and the log is {}", videoName,logName);
 
                 selenoidOptions.put("enableLog", true);
                 selenoidOptions.put("logName ", logName);
@@ -79,7 +80,7 @@ public EdgeUser(String userName, int timeOfWaitInSeconds, String testName, Strin
 
                 //END CAPABILITIES FOR SELENOID RETORCH
 
-                RemoteWebDriver remote = new RemoteWebDriver(new URL(eusApiURL), options);
+                RemoteWebDriver remote = new RemoteWebDriver(new URI(eusApiURL).toURL(), options);
                 remote.setFileDetector(new LocalFileDetector());
 
 

diff --git a/src/test/java/com/fullteaching/e2e/no_elastest/common/FirefoxUser.java b/src/test/java/com/fullteaching/e2e/no_elastest/common/FirefoxUser.java
@@ -24,7 +24,8 @@
 import org.openqa.selenium.remote.RemoteWebDriver;
 
 import java.net.MalformedURLException;
-import java.net.URL;
+import java.net.URI;
+import java.net.URISyntaxException;
 import java.text.SimpleDateFormat;
 import java.time.LocalDateTime;
 import java.time.format.DateTimeFormatter;
@@ -35,7 +36,7 @@
 public class FirefoxUser extends BrowserUser {
     FirefoxOptions options = new FirefoxOptions();
 
-    public FirefoxUser(String userName, int timeOfWaitInSeconds, String testName, String userIdentifier) {
+    public FirefoxUser(String userName, int timeOfWaitInSeconds, String testName, String userIdentifier) throws URISyntaxException {
         super(userName, timeOfWaitInSeconds);
         //TO-DO Firefox configuration has changed, review it.
         FirefoxProfile profile = new FirefoxProfile();
@@ -74,8 +75,7 @@ public FirefoxUser(String userName, int timeOfWaitInSeconds, String testName, St
                 LocalDateTime now = LocalDateTime.now();
                 String logName = dtf.format(now) + "-" + testName + "-" + userIdentifier + ".log";
                 String videoName = dtf.format(now) + "_" + testName + "_" + userIdentifier + ".mp4";
-                log.debug("The data of this test would be stored into: video name " + videoName + " and the log is " + logName);
-
+                log.debug("The data of this test would be stored into: video name {} and the log is {}", videoName,logName);
                 selenoidOptions.put("enableLog", true);
                 selenoidOptions.put("logName ", logName);
                 selenoidOptions.put("videoName", videoName);
@@ -86,7 +86,7 @@ public FirefoxUser(String userName, int timeOfWaitInSeconds, String testName, St
 
                 //END CAPABILITIES FOR SELENOID RETORCH
 
-                RemoteWebDriver remote = new RemoteWebDriver(new URL(eusApiURL), options);
+                RemoteWebDriver remote = new RemoteWebDriver(new URI(eusApiURL).toURL(), options);
                 remote.setFileDetector(new LocalFileDetector());
 
 
@@ -99,7 +99,6 @@ public FirefoxUser(String userName, int timeOfWaitInSeconds, String testName, St
             }
         }
 
-        //this.driver.manage().timeouts().setScriptTimeout(this.timeOfWaitInSeconds, TimeUnit.SECONDS);
 
         this.configureDriver();
     }

diff --git a/src/test/java/com/fullteaching/e2e/no_elastest/common/ForumNavigationUtilities.java b/src/test/java/com/fullteaching/e2e/no_elastest/common/ForumNavigationUtilities.java
@@ -15,10 +15,8 @@
 import java.util.List;
 
 import static com.fullteaching.e2e.no_elastest.common.Constants.*;
-import static java.lang.invoke.MethodHandles.lookup;
 import static org.junit.jupiter.api.Assertions.assertFalse;
 import static org.junit.jupiter.api.Assertions.assertTrue;
-import static org.slf4j.LoggerFactory.getLogger;
 
 
 public class ForumNavigationUtilities {
@@ -72,7 +70,7 @@ public static WebElement getEntry(WebDriver wd, String entry_name) throws Elemen
             try {
                 WebElement title = entry.findElement(FORUM_ENTRY_LIST_ENTRY_TITLE);
                 String title_text = title.getText();
-                if (title_text == null || title_text.equals("")) {
+                if (title_text == null || title_text.isEmpty()) {
                     title_text = title.getAttribute("innerHTML");
                 }
                 if (entry_name.equals(title_text)) {

diff --git a/src/test/java/com/fullteaching/e2e/no_elastest/common/NavigationUtilities.java b/src/test/java/com/fullteaching/e2e/no_elastest/common/NavigationUtilities.java
@@ -13,8 +13,6 @@
 
 import static com.fullteaching.e2e.no_elastest.common.BaseLoggedTest.HOST;
 import static com.fullteaching.e2e.no_elastest.common.Constants.*;
-import static java.lang.invoke.MethodHandles.lookup;
-import static org.slf4j.LoggerFactory.getLogger;
 
 
 public class NavigationUtilities {

diff --git a/src/test/java/com/fullteaching/e2e/no_elastest/common/SessionNavigationUtilities.java b/src/test/java/com/fullteaching/e2e/no_elastest/common/SessionNavigationUtilities.java
@@ -29,7 +29,7 @@ public static WebElement getSession(WebDriver wd, String session_name) throws El
             try {
                 WebElement title = session.findElement(SESSION_LIST_SESSION_NAME);
                 String title_text = title.getText();
-                if (title_text == null || title_text.equals("")) {
+                if (title_text == null || title_text.isEmpty()) {
                     title_text = title.getAttribute("innerHTML");
                 }
                 if (session_name.equals(title_text)) {

diff --git a/src/test/java/com/fullteaching/e2e/no_elastest/common/SpiderNavigation.java b/src/test/java/com/fullteaching/e2e/no_elastest/common/SpiderNavigation.java
@@ -35,10 +35,9 @@ public static List<WebElement> getPageLinks(WebDriver wd) { //29 lines
         List<WebElement> a_lst = wd.findElements(By.tagName("a"));
         for (WebElement a : a_lst) {
             String href = a.getAttribute("href");
-            if ((href != null) && (!href.trim().equals("")) && (!href.contains("#"))) {
-                if (isContainedIn(href.trim(), links_href) && href.contains(host))
+            if ((href != null) && (!href.trim().isEmpty()) && (!href.contains("#")) && isContainedIn(href.trim(), links_href) && href.contains(host))
                     links.add(a);
-            }
+
         }
         return links;
     }
@@ -54,10 +53,8 @@ public static List<WebElement> getUnexploredPageLinks(WebDriver wd, Map<String,
         List<WebElement> allLinks = getPageLinks(wd);
         for (WebElement a : allLinks) {
             String href = a.getAttribute("href");
-            if ((href != null) && (!href.trim().equals("")) && (!href.contains("#"))) {
-                if (isContainedIn(href.trim(), explored.keySet()) && href.contains(host)) //8lines
-                    links.add(a);
-            }
+            if ((href != null) && (!href.trim().isEmpty()) && (!href.contains("#")) && isContainedIn(href.trim(), explored.keySet()) && href.contains(host))
+                links.add(a);
         }
         return links;
     }
@@ -102,20 +99,18 @@ private static boolean isContainedIn(String href, Set<String> set) { // 8lines
     }
 
     public static Set<String> addNonExistentLink(Set<String> original, String href) { //5lines
-        if ((href != null) && (!href.equals("")) && (!href.contains("#"))) {
-            if (isContainedIn(href, original) && href.contains(host))
+        if ((href != null) && (!href.isEmpty()) && (!href.contains("#")) && isContainedIn(href, original) && href.contains(host))
                 original.add(href);
-        }
+
         return original;
     }
 
     public static List<String> discardExplored(List<String> new_links, Set<String> explored) { //8 lines
         List<String> withOutExplored = new ArrayList<>();
         for (String href : new_links) {
-            if ((href != null) && (!href.equals("")) && (!href.contains("#"))) {
-                if (isContainedIn(href, explored) && href.contains(host))
+            if ((href != null) && (!href.isEmpty()) && (!href.contains("#")) && isContainedIn(href, explored) && href.contains(host))
                     withOutExplored.add(href);
-            }
+
         }
         return withOutExplored;
     }

diff --git a/src/test/java/com/fullteaching/e2e/no_elastest/common/UserUtilities.java b/src/test/java/com/fullteaching/e2e/no_elastest/common/UserUtilities.java
@@ -14,8 +14,6 @@
 import org.slf4j.LoggerFactory;
 
 import static com.fullteaching.e2e.no_elastest.common.Constants.*;
-import static java.lang.invoke.MethodHandles.lookup;
-import static org.slf4j.LoggerFactory.getLogger;
 
 
 public class UserUtilities {