-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix zombie processes created by FullTeaching test suite #145
Fix zombie processes created by FullTeaching test suite #145
Conversation
Refractoring to the base test class, making all test cases parametrized and avoiding differences between test cases Also minor fixes related to smells that sonar and IntelliJ detect
e7ee111
to
684a195
Compare
684a195
to
05ffc25
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is mixing too many things, and the goal was to fix a problem, not to refactor all tests. Please DO NOT SUBMIT THIS KIND OF PRs again.
Main issues:
- duplicated code
- handling of exceptions in tests
src/test/java/com/fullteaching/e2e/no_elastest/common/BaseLoggedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/fullteaching/e2e/no_elastest/common/BaseLoggedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/fullteaching/e2e/no_elastest/common/BaseLoggedTest.java
Outdated
Show resolved
Hide resolved
src/test/java/com/fullteaching/e2e/no_elastest/functional/test/LoggedLinksTests.java
Show resolved
Hide resolved
src/test/java/com/fullteaching/e2e/no_elastest/functional/test/UserTest.java
Outdated
Show resolved
Hide resolved
- Removing exceptions where its handling its not appropiate. - Removing blank and double-blank lines
- Adding exception to logintest
- Not used imports - Replace string concatenation with {} - Replace <= lists with .empty method
Sorry for including a lot of changes in this PR @javiertuya. When I started to look for the problem with the zombie processes, I found several main causes, so I addressed all:
So I tried to manage all and try to include in the same PR the changes to resolve the problem. |
@augustocristian Some after-merge comments:
|
This PR is related to #52 and closes #135, solves the remaining problem with the zombie processes, and improves the suite's maintainability and understability.
Contains the following improvements: