Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring to {Base,Edge,Chrome,Firefox}Browser classes to reduce duplicated code and improve mainteinability #148

Conversation

augustocristian
Copy link
Contributor

Related with #52 closes #147 and closes #146

  • Two new methods, that instantiate a RemoteWebDriver and sets the common capabilities
  • Improved and removed code not necessary

@augustocristian augustocristian linked an issue Aug 20, 2024 that may be closed by this pull request
@augustocristian augustocristian force-pushed the 146-reduce-the-duplicated-code-in-base-chrome-edge-firefoxuser branch from b7f6f5f to 6fc15cf Compare August 20, 2024 16:54
…code:

- Two new methods, that instantiate a remotedriver and sets the common capabilities
- Improved and removed code not necessary
@augustocristian augustocristian force-pushed the 146-reduce-the-duplicated-code-in-base-chrome-edge-firefoxuser branch from 6fc15cf to 6a1ac8d Compare August 20, 2024 18:38
@javiertuya javiertuya merged commit a17e653 into main Aug 20, 2024
2 checks passed
@javiertuya javiertuya deleted the 146-reduce-the-duplicated-code-in-base-chrome-edge-firefoxuser branch August 20, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants