Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging improved and stored in separate folders (one for each TJob) #56

Merged
merged 3 commits into from
Dec 11, 2023
Merged

Logging improved and stored in separate folders (one for each TJob) #56

merged 3 commits into from
Dec 11, 2023

Conversation

augustocristian
Copy link
Contributor

Adjusted dependencies to align with the base project of GIIS.
Removed loggers that were redundantly duplicating the base logger of the project.
Refactored and cleaned the code.

javiertuya
javiertuya approved these changes Dec 11, 2023
View reviewed changes
Copy link
Contributor

@javiertuya javiertuya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if it is really needed to change logging in fullteaching as is an application that already had the tests, and so, it should be touched as least as possible, but ok.

@javiertuya javiertuya merged commit aeb5c06 into main Dec 11, 2023
2 checks passed
@javiertuya javiertuya deleted the ft_improvinglogging branch December 11, 2023 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@javiertuya javiertuya javiertuya approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@augustocristian @javiertuya