Skip to content
This repository has been archived by the owner on Jun 26, 2020. It is now read-only.

BugFix/pmid-parsing #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ritvikvipra
Copy link

@ritvikvipra ritvikvipra commented May 7, 2020

This will fix the PMID parsing issue in articles for which currently multiple PMID's are getting parsed.
Resolves issue #22

All Submissions:

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same update/change?

New Feature Submissions:

  1. Does your submission pass tests (if applicable)?
  2. Have you lint your code locally prior to submission (use flake8)?

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

multiple PMID's are getting parsed. Those other id's are likely the PMID's
of cited articles in the article under consideration.
resolves gijswobben#22
@ritvikvipra
Copy link
Author

Update: I didn't see this before. Another solution present at PR #30 which also has the change I implemented as an alternative option mentioned in commit message. @iacopy gets credit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant