Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cache.open catch fallback #235

Merged

Conversation

peter-cardenas-ai
Copy link
Contributor

fixes #234

Copy link

codesandbox bot commented Nov 7, 2024

Review or Edit in CodeSandbox

Open the branch in Web EditorVS CodeInsiders

Open Preview

Copy link

codesandbox-ci bot commented Nov 7, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9a618d5:

Sandbox Source
react-inlinesvg-demo Configuration

@gilbarbara gilbarbara self-requested a review November 12, 2024 13:00
Copy link
Owner

@gilbarbara gilbarbara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the comment I left, LGTM.

src/modules/cache.ts Outdated Show resolved Hide resolved
Copy link
Owner

@gilbarbara gilbarbara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilbarbara gilbarbara changed the title fix: call onReady subscribers even when cache open fails Fix cache.open catch fallback Nov 14, 2024
@gilbarbara gilbarbara merged commit 8148de4 into gilbarbara:main Nov 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When persistent cache fails to open, icons infinitely load
2 participants