Fix tracing-flame bugs and add some config options #320
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, enabling the `tracing_flame` or `allow_jaeger` options would prevent any logs from being written to stdout. In addition, enabling the `allow_jaeger` option would inhibit the `tracing_flame` option. Now that we have a way to use separate tracing filters with different layers, we can enable all three at the same time without issues. This commit also prevents the `debug log_level` command from modifying the `tracing-flame` filter. This was supported previously, but I don't think it's something that you would ever want to do intentionally. Now that we have both the normal log filter and the `tracing-flame` filter enabled at the same time, we want to `debug log_level` to only modify the normal filter.
The previous hardcoded filter `trace,h2=off` isn't appropriate in all cases, it's better to have this be configurable.
Previously we were dropping the flush guard early, possibly causing samples to be lost on exit.
Hardcoding the output path to something in CWD is a pain if you're running conduwuit through systemd or similar. Also made the error message when it's unable to create the output file a little more friendly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bugs fixed:
I also added a couple options to make tracing_flame that were necessary to use tracing-flame on our HS.
The refactoring that fixed the first bug (stdout logging being disabled) also fixed a similar bug for jaeger. Even after this fix, jaeger is still not working because we're initializing it outside of the tokio context. If you try to run conduwuit with
allow_jaeger = true, it will panic. We discussed removing jaeger support instead of fixing it in the matrix room, but I'm going to save that for a later PR. I might try making a janky patch to get jaeger working and see if it's useful for debugging problems on our HS first.