Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency typescript to ~5.7.0 #70

Closed
wants to merge 1 commit into from

Conversation

gisbdzhch
Copy link
Contributor

@gisbdzhch gisbdzhch commented Dec 2, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
typescript (source) ~5.5.4 -> ~5.7.0 age adoption passing confidence

Release Notes

microsoft/TypeScript (typescript)

v5.7.3: TypeScript 5.7.3

Compare Source

For release notes, check out the release announcement.

Downloads are available on npm

v5.7.2: TypeScript 5.7

Compare Source

For release notes, check out the release announcement.

Downloads are available on:

v5.6.3: TypeScript 5.6.3

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:

v5.6.2: TypeScript 5.6

Compare Source

For release notes, check out the release announcement.

For the complete list of fixed issues, check out the

Downloads are available on:


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot.

@gisbdzhch gisbdzhch enabled auto-merge (squash) December 2, 2024 15:02
@gisbdzhch gisbdzhch requested a review from a team December 2, 2024 15:02
@gisbdzhch gisbdzhch force-pushed the renovate/typescript-5.x branch 8 times, most recently from 0318e40 to 61dd914 Compare December 7, 2024 02:59
@gisbdzhch gisbdzhch force-pushed the renovate/typescript-5.x branch 5 times, most recently from c4a7200 to e8d5b7f Compare December 13, 2024 03:02
@gisbdzhch gisbdzhch force-pushed the renovate/typescript-5.x branch 2 times, most recently from ad235f4 to fc5449c Compare December 18, 2024 02:56
@Tugark Tugark mentioned this pull request Jan 7, 2025
@Tugark
Copy link
Contributor

Tugark commented Jan 14, 2025

@wendlans This cannot be updated, even with angular 19 (see #91 (comment)). We _could_fix the buildtime compiler warning for @uppy, but not for @arcgis.

As such, I think it's a bit dangerous to have these updates in renovate, because the build is seemingly working. We'll have to wait and see what happens when our pipelines are fixed next sprint.

@gisbdzhch gisbdzhch force-pushed the renovate/typescript-5.x branch 11 times, most recently from 06d5b0f to 3894442 Compare January 27, 2025 02:09
@Tugark
Copy link
Contributor

Tugark commented Jan 27, 2025

@wendlans This cannot be merged since it breaks with angular during install (Angular 19 requires <5.7); and it would break during runtime due to arcgis.

I think we could exclude typescript from renovate config, since it's highly likely that this will always have some issues (I mean, no packages will use bleeding edge versions, I guess). Thoughts?

Note: We could try and manually update to 5.6, but I'm not sure it is worth the hassle. Actually no, because that would break arcgis :)

@gisbdzhch gisbdzhch force-pushed the renovate/typescript-5.x branch 3 times, most recently from 2d88380 to c17899c Compare January 28, 2025 03:10
@wendlans
Copy link
Contributor

@wendlans This cannot be merged since it breaks with angular during install (Angular 19 requires <5.7); and it would break during runtime due to arcgis.

I think we could exclude typescript from renovate config, since it's highly likely that this will always have some issues (I mean, no packages will use bleeding edge versions, I guess). Thoughts?

Note: We could try and manually update to 5.6, but I'm not sure it is worth the hassle. Actually no, because that would break arcgis :)

@Tugark AFAIK we can block Typescript entirely from the Renovate config. The effect would be that Typescript wouldn't be mentioned even in case Angular gets updated.
Should we do that including patch level changes?

@gisbdzhch gisbdzhch force-pushed the renovate/typescript-5.x branch from c17899c to 3a01582 Compare January 29, 2025 02:06
@Tugark
Copy link
Contributor

Tugark commented Jan 29, 2025

@wendlans This cannot be merged since it breaks with angular during install (Angular 19 requires <5.7); and it would break during runtime due to arcgis.
I think we could exclude typescript from renovate config, since it's highly likely that this will always have some issues (I mean, no packages will use bleeding edge versions, I guess). Thoughts?
Note: We could try and manually update to 5.6, but I'm not sure it is worth the hassle. Actually no, because that would break arcgis :)

@Tugark AFAIK we can block Typescript entirely from the Renovate config. The effect would be that Typescript wouldn't be mentioned even in case Angular gets updated. Should we do that including patch level changes?

Yes, I'd prefer that. We will always have have some issues with it, and it needs manual checking anyhow (given that we cannot reliably trust renovate.

Or: Because I like this as a "reminder", we could also close this PR, then it should not be opened again for this version. It would be opened again, I think, for 5.7.1 - if that happens too frequently, then I would disable typescript in renovate altogether.

Thoughts @wendlans ?

@gisbdzhch gisbdzhch force-pushed the renovate/typescript-5.x branch from 3a01582 to bc989d4 Compare January 29, 2025 07:00
@gisbdzhch gisbdzhch force-pushed the renovate/typescript-5.x branch from bc989d4 to d0a852c Compare January 29, 2025 07:12
@wendlans
Copy link
Contributor

@Tugark AFAIK we can block Typescript entirely from the Renovate config. The effect would be that Typescript wouldn't be mentioned even in case Angular gets updated. Should we do that including patch level changes?

Yes, I'd prefer that. We will always have have some issues with it, and it needs manual checking anyhow (given that we cannot reliably trust renovate.

Or: Because I like this as a "reminder", we could also close this PR, then it should not be opened again for this version. It would be opened again, I think, for 5.7.1 - if that happens too frequently, then I would disable typescript in renovate altogether.

Thoughts @wendlans ?

I'm not sure how good a reminder is that we don't really use. On the other hand if it does not pop up every day we should be fine. I think we can go with the later for now. @Tugark I'll close this PR for now.

@wendlans wendlans closed this Jan 29, 2025
auto-merge was automatically disabled January 29, 2025 08:00

Pull request was closed

@Tugark
Copy link
Contributor

Tugark commented Jan 29, 2025

@Tugark AFAIK we can block Typescript entirely from the Renovate config. The effect would be that Typescript wouldn't be mentioned even in case Angular gets updated. Should we do that including patch level changes?

Yes, I'd prefer that. We will always have have some issues with it, and it needs manual checking anyhow (given that we cannot reliably trust renovate.
Or: Because I like this as a "reminder", we could also close this PR, then it should not be opened again for this version. It would be opened again, I think, for 5.7.1 - if that happens too frequently, then I would disable typescript in renovate altogether.
Thoughts @wendlans ?

I'm not sure how good a reminder is that we don't really use. On the other hand if it does not pop up every day we should be fine. I think we can go with the later for now. @Tugark I'll close this PR for now.

A reminder in the sense that we know that typescript has a new version and we can (or should) then manually check if it is now working.

Basically, just like I did with this update here :D

@gisbdzhch
Copy link
Contributor Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (~5.7.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@gisbdzhch gisbdzhch deleted the renovate/typescript-5.x branch January 29, 2025 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants