add support for Linux arm64 and Linux arm #1633
Conversation
|
@shiftkey needed to support GitHub Desktop linux on all currently built architectures. Please help this get merged. |
|
bump |
There was a problem hiding this comment.
Thanks for this! Adding Linux ARM support has been a long standing request, but we've just not had time to get around to it, or time to review other submissions.
I think your changes here work good! The only request I have is let's take this time to change the gcm-linux_$ARCH artifact format to match the others: gcm-$RUNTIME.
This way we also only pass the same $RUNTIME argument to all the build scripts, and only compute the $ARCH for the Debian control file in pack.sh.
theofficialgman
force-pushed
the
new-add-linux-arm
branch
from
af5de74
to
339b8eb
Compare
Co-Authored-By: Matthew John Cheetham <[email protected]>
theofficialgman
force-pushed
the
new-add-linux-arm
branch
from
339b8eb
to
628acd0
Compare
|
@mjcheetham I implemented the changes, squashed (since there was really no need to keep the history, it just would make it more confusing), and gave you co-authorship. The changes should be finished. |
|
@mjcheetham https://github.com/git-ecosystem/git-credential-manager/actions/runs/11706008472/job/32602083045#step:5:344 that is an oversight. I was not aware this scripting was used in anything other than the debian based release actions. |
Thanks for alerting me. I am looking at this now. |
@mjcheetham this should fix this #1633 (comment) it also fixes as a side effect the alpine linux build from source being built against the wrong [glibc linux (linux-x64)](https://github.com/git-ecosystem/git-credential-manager/actions/runs/11573830139/job/32216761503#step:5:142) runtime instead of the correct [musl linux (linux-musl-x64)](https://github.com/theofficialgman/git-credential-manager/actions/runs/11706600286/job/32604070640#step:5:142) runtime full test run: https://github.com/theofficialgman/git-credential-manager/actions/runs/11706600286
|
@mjcheetham now that this has been included for a few weeks, is there any timeline for a new release to be made? I know there are some dependent projects waiting on this. |
Adds support for building and publishing Linux ARM64 and Linux ARM32
replaces #237
replaces #1526
closes #606
needed for GitHub Desktop which uses dugite desktop/desktop#18700 desktop/dugite-native#510
CC @niik @shiftkey
continuous-integration works https://github.com/theofficialgman/git-credential-manager/actions/runs/9391634166
can't test release due to lack of keys