Fix nano's syntax coloring
#605
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to startle the reader if that directory is not found; That's okay. Signed-off-by: Johannes Schindelin <[email protected]>
As of [v8.2~7](https://git.savannah.gnu.org/cgit/nano.git/commit/doc/sample.nanorc.in?id=ebddb49041c7), the commented-out `include *.nanorc` directives in `/etc/nanorc` no longer enclose their arguments in double-quotes. Let's adjust the post-install script that wants to uncomment those directives. This fixes git-for-windows/git#5462. Signed-off-by: Johannes Schindelin <[email protected]>
When determining the current package version, we already ignore changes to the `pkgver` line in `PKGBUILD`, which is auto-generated by the `pkgver()` function of `PKGBUILD`. Let's do the same for the auto-generated changes to `git-extra.install`, which is generated from `gitconfig`, `gitattributes` and `git-extra.install.in`. Signed-off-by: Johannes Schindelin <[email protected]>
The `makepkg-mingw` build updated the version and `git-extra.install`. Signed-off-by: Johannes Schindelin <[email protected]>
|
/deploy git-extra The i686/x86_64 and the arm64 workflow runs were started. |
|
/add relnote bug The syntax highlighting of the The workflow run was started |
github-actions bot
pushed a commit
that referenced
this pull request
Mar 5, 2025
The [syntax highlighting of the `nano` editor was recently disabled](git-for-windows/git#5462) in Git for Windows by mistake, which [was fixed](#605). Signed-off-by: gitforwindowshelper[bot] <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A change in nano v8.2 rendered Git for Windows' logic to enable syntax coloring in
nanonon-functional. Let's fix this, along with a couple other minor things I found on the way.This fixes git-for-windows/git#5462