Fix files selection #4764
Merged
Fix files selection #4764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
krlvi
approved these changes
Aug 27, 2024
mtsgrd
reviewed
Aug 27, 2024
Comment on lines
11
to
13
| const nextFile = | ||
| fileIndex !== -1 && fileIndex + 1 < files.length ? files[fileIndex + 1] : undefined; | ||
| return nextFile; |
There was a problem hiding this comment.
It looks like this is a no-op change?
There was a problem hiding this comment.
I'm checking if fileIndex is greater than 0 and within the bounds of the files array. If both conditions are true, the code returns the next file in the array. Otherwise, it returns undefined.
Can you suggest a better solution here?
There was a problem hiding this comment.
The only change you're making here is declaring the variable nextFile and then immediately removing it. Perhaps you meant to modify the expression?
There was a problem hiding this comment.
Ah, I see. Sure, I'll fixed that
PavelLaptev
force-pushed
the
Fix-files-selection
branch
from
62323fd to
71eca8f
Compare
PavelLaptev
force-pushed
the
Fix-files-selection
branch
from
71eca8f to
851d652
Compare
mtsgrd
reviewed
Aug 28, 2024
Comment on lines
16
to
19
| return fileIndex > 0 ? files[fileIndex - 1] : undefined; | ||
| const previousFile = fileIndex > 0 ? files[fileIndex - 1] : undefined; | ||
| return previousFile; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
commit idand there wasn't any matches.remotecommitsdraggableicon for unapplied commitsResult:
Screen.Recording.2024-08-26.at.23.44.57.mov
Related issue — #4734 (comment)