Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: File key navigation and selection #4876

Merged
merged 1 commit into from
Sep 11, 2024
Merged

fix: File key navigation and selection #4876

merged 1 commit into from
Sep 11, 2024

Conversation

estib-vega
Copy link
Contributor

@estib-vega estib-vega commented Sep 11, 2024 •
edited
Loading

☕️ Reasoning

Partially mentioned here: #4734 (comment)

This fixes the file list navigation to work as expected

🧢 Changes

  • Navigating with the up or down arrow keys works as expected
  • Holding down shift while navigating also works as expected
  • If selecting multiply files, up-arrow will de-select everything except the top file
  • If selecting multiply files, down-arrow will de-select everything except the bottom file

@PavelLaptev PavelLaptev self-requested a review September 11, 2024 11:30
PavelLaptev
PavelLaptev approved these changes Sep 11, 2024
View reviewed changes
Copy link
Contributor

@PavelLaptev PavelLaptev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works good 👍 thanks @estib-vega

@estib-vega estib-vega merged commit 2d8b823 into master Sep 11, 2024
12 checks passed
@estib-vega estib-vega deleted the file-navigation branch September 11, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PavelLaptev PavelLaptev PavelLaptev approved these changes

@mtsgrd mtsgrd Awaiting requested review from mtsgrd

@ndom91 ndom91 Awaiting requested review from ndom91

@Caleb-T-Owens Caleb-T-Owens Awaiting requested review from Caleb-T-Owens

Assignees
No one assigned
Labels
@gitbutler/desktop
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@estib-vega @PavelLaptev