Add some nice keyboard shortcuts for staging and selecting #4884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pressing 'Escape' will close the commit input file
Add the ability to control externally when the commit message text input is focused. Also: Opent the commit input when a file is selected and the space bar is pressed
Stage or unstage the files by pressing the space-bar on the selected files. Click enter to focus on the commit message input field
Select all files with meta-key + 'a'. Also, `fileIdSelection` will make sure that the no duplicates are added to the selection
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
estib-vega
changed the title
estib-vega
force-pushed
the
keyboard-shortcuts
branch
from
5048f16 to
5137517
Compare
mtsgrd
reviewed
Sep 16, 2024
| return; | ||
| } | ||
|
|
||
| // Stage/unstage files |
There was a problem hiding this comment.
Maybe remove these comments as they are not super helpful.
mtsgrd
reviewed
Sep 16, 2024
Comment on lines
223
to
226
| // Only one file selected | ||
| // | ||
| // Select all hunks if none are selected, | ||
| // otherwise ignore all hunks |
There was a problem hiding this comment.
Any chance you could format and punctuate this a bit better? I see one comma, and two questionable line breaks 😂
There was a problem hiding this comment.
Don't, you, like
.them?
There was a problem hiding this comment.
Haha, I'll just remove them 👍
mtsgrd
approved these changes
Sep 16, 2024
estib-vega
force-pushed
the
keyboard-shortcuts
branch
from
a31fc3b to
c9a5d7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
☕️ Reasoning
As seen in #4734
DISCLAIMER
Not all items in that issue are implemented in this PR.
It would be great if we and stage/un-stage files using only the keys!
🧢 Changes
'Escape'will close the commit message input field (both the modal and the lane field)Ctrl or cmd + 'a'will select all files in the listspace-barwill open the commit message input from the lane.space-barwill toggle the staging of the selected files.