feat: css gap utils #6203
Open
feat: css gap utils #6203
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ndom91
force-pushed
the
feat-gap-utilities
branch
from
9dac227 to
a441834
Compare
|
Following from our conversation earlier, can we try and accomplish this without |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧢 Changes
gaputility classes!importanton these util classes?Linkhas a predefinedgap: 2pxin it's scoped styles for the classlink. Which oddly also comes before our prop class, so you'd think our prop classes would override it (i.e. something likeclass="link ${classes}"), but I guess it wins on specificity due to the additional svelte scoping auto-generated class name 🤷☕️ Reasoning