Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OS Notifications #7399

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

OS Notifications #7399

wants to merge 3 commits into from

Conversation

estib-vega
Copy link
Contributor

  • OS Notifications Module:

    • Introduces a new module for sending OS application notifications from the frontend.
    • Provides a utility for easier integration of notifications in the application.
  • Rust Toolchain Stabilization:

    • Reverts to the stable version of the Rust toolchain.
    • Avoids the use of the experimental checked_signed_diff method for safe u32 subtraction.
    • Updates the hash snapshots to ensure compatibility and stability.

Note: macOS users must enable notifications for the Terminal application during development to receive notifications.

Copy link

vercel bot commented Feb 25, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
gitbutler-components ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 8:46am
gitbutler-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 26, 2025 8:46am

@estib-vega
Copy link
Contributor Author

Damnnnn, so the current blocker for this is that the application needs to be in the Cargo nightly toolchain, in order to access the experimental feature windows_by_handle rust-lang/rust#63010, that exposes some needed metadata.

Tauri notifications have a transitive dependency that breaks on the Cargo nightly toolchain...

This kind of sucks

@estib-vega
Copy link
Contributor Author

This is the dependency's issue about breaking on nightly h4llow3En/mac-notification-sys#64

@estib-vega
Copy link
Contributor Author

Next thing to try: basharovV/musicat#69 (comment)

Apparently we might be able to forgo the experimental Windows utils for that package.
Need to test that in a Windows machine, though

Go back to overriding the version of the Rust toolchain to be the stable one.
This means that there are two adaptions to make:
1. Don't use the experimental `checked_signed_diff`method for safe u32 subtraction
2. Update the hash snapshots
Create a module that exposes an utility for sending OS application notifications from the frontend.

**Disclaimer**: macOS users need to enable notifications for the Terminal application in order to get the notifications to work while on development.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@gitbutler/desktop rust Pull requests that update Rust code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant