Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add collections #2628

Merged
merged 4 commits into from
Nov 17, 2023
Merged

Add collections #2628

merged 4 commits into from
Nov 17, 2023

Conversation

carlbarrdahl
Copy link
Contributor

Todo

  • Add images
  • Update layout

PR checklist

For every PR, make sure that these statements are true:

  • Includes only changes relevant to the original ticket. Significant refactoring needs to be separated.
  • Doesn't contain type casts and non-null assertions.
  • Doesn't add @ts-ignore.
  • Doesn't disable lints.
  • Doesn't use useState just for computation - use plain variables instead.
  • Splits components into pure components that don't depend on external state or hooks.
  • Avoid embedding components within other components
  • Doesn't propagate optional values without good reason, doesn't mark property values as optional if that doesn't represent reality.
  • Doesn't duplicate existing code.
  • Parses out-of-domain data - this includes user input, API respones, on-chain data etc.
  • Doesn't contain commented out code.
  • Doesn't contain skipped or empty tests.
  • If this PR adds/updates any feature, it adds/updates its test script

Subjective - at the discretion of the reviewers

  • Does things as simply as possible, but not simpler.
  • Doesn't reinvent the wheel or create premature abstractions.
Description
Refers/Fixes

fixes #issuenumber

Copy link

vercel bot commented Nov 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
builder ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 10:04am
builder-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 10:04am
explorer ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 10:04am
explorer-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 10:04am
manager ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 10:04am
manager-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 17, 2023 10:04am

Copy link

gitstream-cm bot commented Nov 17, 2023

🥷 Code experts: boudra

carlbarrdahl, boudra have most 👩‍💻 activity in the files.
carlbarrdahl, boudra have most 🧠 knowledge in the files.

See details

packages/grant-explorer/src/features/collections/CollectionDetails.tsx

Activity based on git-commit:

carlbarrdahl boudra
NOV 79 additions & 13 deletions 28 additions & 0 deletions
OCT
SEP
AUG
JUL
JUN

Knowledge based on git-blame:
carlbarrdahl: 84%
boudra: 16%

packages/grant-explorer/src/features/collections/CollectionsGrid.tsx

Activity based on git-commit:

carlbarrdahl boudra
NOV 36 additions & 15 deletions
OCT
SEP
AUG
JUL
JUN

Knowledge based on git-blame:
carlbarrdahl: 100%

packages/grant-explorer/src/features/collections/hooks/useCollections.ts

Activity based on git-commit:

carlbarrdahl boudra
NOV 58 additions & 121 deletions 132 additions & 14 deletions
OCT
SEP
AUG
JUL
JUN

Knowledge based on git-blame:
carlbarrdahl: 75%
boudra: 25%

packages/grant-explorer/src/features/discovery/CardBanner.tsx

Activity based on git-commit:

carlbarrdahl boudra
NOV 31 additions & 16 deletions
OCT 109 additions & 0 deletions
SEP
AUG
JUL
JUN

Knowledge based on git-blame:
carlbarrdahl: 45%

To learn more about /:\ gitStream - Visit our Docs

Copy link

gitstream-cm bot commented Nov 17, 2023

This PR is 99.29245283018868% new code.

@carlbarrdahl carlbarrdahl merged commit 7e7f3eb into main Nov 17, 2023
@carlbarrdahl carlbarrdahl deleted the 2620-add-collections branch November 17, 2023 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explorer: add 5 new Collections from Curators
3 participants