-
-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance the Client to retrieve user name asynchronously #12
Conversation
Required for gitextensions/gitextensions#6752 |
I was afraid to break backward compatibility by removing this method.
Could you please elaborate?
Each version of GE is tight to a particular commit of GE/GH repo. This
change will produce a new commit, and GE 3.2 will be tight to the new
commit.
Is there something else I am missing?
…On Thu, 6 Jun 2019 at 07:06, Gerhard Olsson ***@***.***> wrote:
***@***.**** approved this pull request.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#12?email_source=notifications&email_token=ABBTEXTCVD2S4AL62LRPSVLPZATFVA5CNFSM4HTKDXD2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOB2WZWLI#pullrequestreview-246258477>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABBTEXT4CB7HKZDON2B2SMLPZATFVANCNFSM4HTKDXDQ>
.
|
Well, it will never be a problem for GE itself, as you mentioned, since GE has a reference to the new version of GH, however, it could potentially be a problem for any other application who use GH as an external reference. I'm a newbie here and most likely overcomplicating things, but since GH is separated repository which has a bunch of public API classes, so someone can easily be dependant on the method that might seem to be redundant for GE. If GH has never been assumed to be exposed as public API for any consumer except for GE, then I totally agree, we should reduce redundancy as much as possible. |
The origin repo is used by others but our fork is only intended to be used by us. The fork has diverged and is not likely to be merged upstream. So delete. |
Ok, removed then. |
To make GE scrolling performance smoother when the avatar column is shown.