Better handle GitHub bad token #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just review the first commit. |
RussKie
requested changes
Apr 28, 2020
Git.hub/Client.cs
Outdated
| repo.Detailed = true; | ||
| return repo; | ||
| } | ||
|
|
||
| private T DoRequest<T>(IRestRequest request, bool shouldNotFail = false) where T : new() |
There was a problem hiding this comment.
Please invert shouldNotFail. It leads to a mental overload when staring at true to understand what it means.
Suggested change
| private T DoRequest<T>(IRestRequest request, bool shouldNotFail = false) where T : new() | |
| private T DoRequest<T>(IRestRequest request, bool throwOnError = true) where T : new() |
RussKie
reviewed
Apr 28, 2020
Git.hub/Client.cs
Outdated
| @@ -112,6 +113,32 @@ public Repository getRepository(string username, string repositoryName) | |||
| return repo; | |||
| } | |||
|
|
|||
| private T DoRequest<T>(RestRequest request, bool shouldNotFail = false) where T : new() | |||
There was a problem hiding this comment.
Please move the private method after publics.
gerhardol
approved these changes
Apr 28, 2020
| if (repos == null || repos.Repositories == null) | ||
| throw new Exception(string.Format("Could not search for {0}", query)); | ||
| var repos = DoRequest<APIv2.RepositoryListV2>(request); | ||
| if (repos?.Repositories == null) |
There was a problem hiding this comment.
Maybe add {} to conform with GE style (but will not be the same as other files in this submodule)
pmiossec
force-pushed
the
better_handle_github_bad_token
branch
from
95e9f55 to
3605b4a
Compare
|
Updated. |
pmiossec
force-pushed
the
better_handle_github_bad_token
branch
from
3605b4a to
7a99961
Compare
RussKie
approved these changes
Apr 28, 2020
gerhardol
approved these changes
Apr 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transform a NRE in an UnauthorizedAccessException with clearer message
First step to handle gitextensions/gitextensions#7641