Migrate code to latest RestSharp version #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OAuth2Authenticator is obsolete now ExecuteGetTaskAsync was renamed to ExecuteGetAsync
RussKie
approved these changes
May 27, 2020
pmiossec
approved these changes
May 30, 2020
Git.hub/OAuth2Helper.cs
Outdated
| request.AddHeader("Authorization", "bearer " + AccessToken); | ||
| protected override Parameter GetAuthenticationParameter(string accessToken) | ||
| { | ||
| return new Parameter("Authorization", "bearer " + Token, ParameterType.HttpHeader); |
There was a problem hiding this comment.
Just a question. Is there a reason to use Token instead of the parameter accessToken that seems to contains the same value?
If not, for readability, I would use accesToken instead...
There was a problem hiding this comment.
I think it does the same thing and agree accessToken is more readable
gerhardol
approved these changes
May 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is complementary to gitextensions/gitextensions#8123
OAuth2Authenticator is obsolete now, rewriten to new AuthenticatorBase. I looked to RestSharp repo before and after and my change should be 1:1 as before. I tested this change in GitExtensions with "Plugins > GitHub" and created token successfully.
ExecuteGetTaskAsync was renamed to ExecuteGetAsync.