feat: migrate launch template to use SSM for AMI lookup #4517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 31, 2025
dgokcin
reviewed
Apr 1, 2025
Bumps [vitest](https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest) from 3.0.9 to 3.1.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/vitest-dev/vitest/releases">vitest's releases</a>.</em></p> <blockquote> <h2>v3.1.1</h2> <h3> 🐞 Bug Fixes</h3> <ul> <li><strong>reporter</strong>: <ul> <li>Report tests in correct order - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7752">vitest-dev/vitest#7752</a> <a href="https://github.com/vitest-dev/vitest/commit/b166efa2"><!-- raw HTML omitted -->(b166e)<!-- raw HTML omitted --></a></li> <li>Print test only once in the verbose mode - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7738">vitest-dev/vitest#7738</a> <a href="https://github.com/vitest-dev/vitest/commit/69ca425c"><!-- raw HTML omitted -->(69ca4)<!-- raw HTML omitted --></a></li> </ul> </li> </ul> <h5> <a href="https://github.com/vitest-dev/vitest/compare/v3.1.0...v3.1.1">View changes on GitHub</a></h5> <h2>v3.1.0</h2> <h3>🚀 Features</h3> <ul> <li>Introduce <code>%$</code> option to add number of the test to its title - by <a href="https://github.com/kemuridama"><code>@kemuridama</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7412">vitest-dev/vitest#7412</a> <a href="https://github.com/vitest-dev/vitest/commit/df3477076"><!-- raw HTML omitted -->(df347)<!-- raw HTML omitted --></a></li> <li>Add <code>diff.maxDepth</code> option and set non-<code>Infinity</code> value as a default to reduce crash - by <a href="https://github.com/hi-ogawa"><code>@hi-ogawa</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7481">vitest-dev/vitest#7481</a> <a href="https://github.com/vitest-dev/vitest/commit/eacab25e7"><!-- raw HTML omitted -->(eacab)<!-- raw HTML omitted --></a></li> <li>Allow array element for <code>test.each/for</code> title formatting - by <a href="https://github.com/hi-ogawa"><code>@hi-ogawa</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7522">vitest-dev/vitest#7522</a> <a href="https://github.com/vitest-dev/vitest/commit/ea3d67b03"><!-- raw HTML omitted -->(ea3d6)<!-- raw HTML omitted --></a></li> <li>Add "configureVitest" plugin hook - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> and <a href="https://github.com/AriPerkkio"><code>@AriPerkkio</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7349">vitest-dev/vitest#7349</a> <a href="https://github.com/vitest-dev/vitest/commit/20a5d4bfc"><!-- raw HTML omitted -->(20a5d)<!-- raw HTML omitted --></a></li> <li>Support <code>--configLoader</code> CLI option - by <a href="https://github.com/Carnageous"><code>@Carnageous</code></a> and <a href="https://github.com/hi-ogawa"><code>@hi-ogawa</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7574">vitest-dev/vitest#7574</a> <a href="https://github.com/vitest-dev/vitest/commit/2a8520a83"><!-- raw HTML omitted -->(2a852)<!-- raw HTML omitted --></a></li> <li>Added <code>vitest-browser-lit</code> to <code>vitest init browser</code> and docs - by <a href="https://github.com/EskiMojo14"><code>@EskiMojo14</code></a> and <a href="https://github.com/hi-ogawa"><code>@hi-ogawa</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7705">vitest-dev/vitest#7705</a> <a href="https://github.com/vitest-dev/vitest/commit/5659a0e0c"><!-- raw HTML omitted -->(5659a)<!-- raw HTML omitted --></a></li> <li>Use providers request interception for module mocking - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7576">vitest-dev/vitest#7576</a> <a href="https://github.com/vitest-dev/vitest/commit/7883acd63"><!-- raw HTML omitted -->(7883a)<!-- raw HTML omitted --></a></li> <li><strong>browser</strong>: <ul> <li>Introduce <code>and</code>, <code>or</code> and <code>filter</code> locators - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> and <a href="https://github.com/AriPerkkio"><code>@AriPerkkio</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7463">vitest-dev/vitest#7463</a> <a href="https://github.com/vitest-dev/vitest/commit/63949b1d7"><!-- raw HTML omitted -->(63949)<!-- raw HTML omitted --></a></li> </ul> </li> <li><strong>reporter</strong>: <ul> <li>Always render test time - by <a href="https://github.com/AriPerkkio"><code>@AriPerkkio</code></a> and <a href="https://github.com/spamshaker"><code>@spamshaker</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7529">vitest-dev/vitest#7529</a> <a href="https://github.com/vitest-dev/vitest/commit/5eba60ae1"><!-- raw HTML omitted -->(5eba6)<!-- raw HTML omitted --></a></li> <li><code>--silent=passed-only</code> to log failed tasks only - by <a href="https://github.com/AriPerkkio"><code>@AriPerkkio</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7530">vitest-dev/vitest#7530</a> <a href="https://github.com/vitest-dev/vitest/commit/f9e1cb494"><!-- raw HTML omitted -->(f9e1c)<!-- raw HTML omitted --></a></li> </ul> </li> <li><strong>runner</strong>: <ul> <li>Add <code>test.scoped</code> to override <code>test.extend</code> fixtures per-suite - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7233">vitest-dev/vitest#7233</a> <a href="https://github.com/vitest-dev/vitest/commit/e5851e4b8"><!-- raw HTML omitted -->(e5851)<!-- raw HTML omitted --></a></li> </ul> </li> <li><strong>vitest</strong>: <ul> <li>Allow conditional <code>context.skip(boolean)</code> - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> and <a href="https://github.com/AriPerkkio"><code>@AriPerkkio</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7659">vitest-dev/vitest#7659</a> <a href="https://github.com/vitest-dev/vitest/commit/6adecb903"><!-- raw HTML omitted -->(6adec)<!-- raw HTML omitted --></a></li> <li>Support rolldown-vite in NormalizeUrlPlugin - by <a href="https://github.com/sapphi-red"><code>@sapphi-red</code></a> and <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7739">vitest-dev/vitest#7739</a> <a href="https://github.com/vitest-dev/vitest/commit/1ef31a7bb"><!-- raw HTML omitted -->(1ef31)<!-- raw HTML omitted --></a></li> </ul> </li> </ul> <h3>🐞 Bug Fixes</h3> <ul> <li>Update test stats regularly - by <a href="https://github.com/hi-ogawa"><code>@hi-ogawa</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7700">vitest-dev/vitest#7700</a> <a href="https://github.com/vitest-dev/vitest/commit/b7953487b"><!-- raw HTML omitted -->(b7953)<!-- raw HTML omitted --></a></li> <li>Fix vm tests flakiness - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7741">vitest-dev/vitest#7741</a> <a href="https://github.com/vitest-dev/vitest/commit/2702cf424"><!-- raw HTML omitted -->(2702c)<!-- raw HTML omitted --></a></li> <li>Set <code>diff.expand: false</code> as default - by <a href="https://github.com/hi-ogawa"><code>@hi-ogawa</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7697">vitest-dev/vitest#7697</a> <a href="https://github.com/vitest-dev/vitest/commit/f34206536"><!-- raw HTML omitted -->(f3420)<!-- raw HTML omitted --></a></li> <li><strong>browser</strong>: <ul> <li>Correctly calculate timeout in hooks when actions are performed - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7747">vitest-dev/vitest#7747</a> <a href="https://github.com/vitest-dev/vitest/commit/a55055180"><!-- raw HTML omitted -->(a5505)<!-- raw HTML omitted --></a></li> </ul> </li> <li><strong>deps</strong>: <ul> <li>Update all non-major dependencies - by <a href="https://github.com/hi-ogawa"><code>@hi-ogawa</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7600">vitest-dev/vitest#7600</a> <a href="https://github.com/vitest-dev/vitest/commit/7fc5a2908"><!-- raw HTML omitted -->(7fc5a)<!-- raw HTML omitted --></a></li> </ul> </li> <li><strong>reporter</strong>: <ul> <li><code>--hideSkippedTests</code> should hide suites too - by <a href="https://github.com/AriPerkkio"><code>@AriPerkkio</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7695">vitest-dev/vitest#7695</a> <a href="https://github.com/vitest-dev/vitest/commit/ba9b51ccc"><!-- raw HTML omitted -->(ba9b5)<!-- raw HTML omitted --></a></li> <li>Report tests in correct order - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7752">vitest-dev/vitest#7752</a> <a href="https://github.com/vitest-dev/vitest/commit/b166efa28"><!-- raw HTML omitted -->(b166e)<!-- raw HTML omitted --></a></li> <li>Print test only once in the verbose mode - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7738">vitest-dev/vitest#7738</a> <a href="https://github.com/vitest-dev/vitest/commit/69ca425c6"><!-- raw HTML omitted -->(69ca4)<!-- raw HTML omitted --></a></li> </ul> </li> <li><strong>snapshot</strong>: <ul> <li>Fix indent normalization - by <a href="https://github.com/hi-ogawa"><code>@hi-ogawa</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7400">vitest-dev/vitest#7400</a> <a href="https://github.com/vitest-dev/vitest/commit/8299709d2"><!-- raw HTML omitted -->(82997)<!-- raw HTML omitted --></a></li> </ul> </li> </ul> <h3>🏎 Performance</h3> <ul> <li><strong>browser</strong>: Fork jest-dom instead of bundling it - by <a href="https://github.com/sheremet-va"><code>@sheremet-va</code></a> in <a href="https://redirect.github.com/vitest-dev/vitest/issues/7605">vitest-dev/vitest#7605</a> <a href="https://github.com/vitest-dev/vitest/commit/12762ea6c"><!-- raw HTML omitted -->(12762)<!-- raw HTML omitted --></a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/vitest-dev/vitest/commit/a9d36c719f8ce5551f61da20181490d3673bdf99"><code>a9d36c7</code></a> chore: release v3.1.1</li> <li><a href="https://github.com/vitest-dev/vitest/commit/69ca425c695805ee19e5d14840df9c9ef6d8e7a4"><code>69ca425</code></a> fix(reporter): print test only once in the verbose mode (<a href="https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest/issues/7738">#7738</a>)</li> <li><a href="https://github.com/vitest-dev/vitest/commit/b166efa285f4f678914008edf4a1b96e9d936dab"><code>b166efa</code></a> fix(reporter): report tests in correct order (<a href="https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest/issues/7752">#7752</a>)</li> <li><a href="https://github.com/vitest-dev/vitest/commit/b8eda4bb1c7a586fb4c8622e3989513e7d57c6a5"><code>b8eda4b</code></a> chore: release v3.1.0</li> <li><a href="https://github.com/vitest-dev/vitest/commit/938da77ee063748cfb12a7f302d2efcef249cf1f"><code>938da77</code></a> fix (ui): rerun individually tests with special chars in name (<a href="https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest/issues/7707">#7707</a>)</li> <li><a href="https://github.com/vitest-dev/vitest/commit/7883acd636192e541860bba436dfb00bb5eaf0e2"><code>7883acd</code></a> feat: use providers request interception for module mocking (<a href="https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest/issues/7576">#7576</a>)</li> <li><a href="https://github.com/vitest-dev/vitest/commit/a7ecd0f495de081ea4819b243da8c48b0b35f1c9"><code>a7ecd0f</code></a> refactor: remove direct imports from rollup (<a href="https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest/issues/7751">#7751</a>)</li> <li><a href="https://github.com/vitest-dev/vitest/commit/5659a0e0ce748f9574c74c2cf90f65bfcf8c0ab8"><code>5659a0e</code></a> feat: Added <code>vitest-browser-lit</code> to <code>vitest init browser</code> and docs (<a href="https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest/issues/7705">#7705</a>)</li> <li><a href="https://github.com/vitest-dev/vitest/commit/2702cf4245ffa543f5b5b2335ab299453870a4e3"><code>2702cf4</code></a> fix: fix vm tests flakiness (<a href="https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest/issues/7741">#7741</a>)</li> <li><a href="https://github.com/vitest-dev/vitest/commit/12762ea6cc1a295cbf6c4cac53b3710fd766fd32"><code>12762ea</code></a> perf(browser): fork jest-dom instead of bundling it (<a href="https://github.com/vitest-dev/vitest/tree/HEAD/packages/vitest/issues/7605">#7605</a>)</li> <li>Additional commits viewable in <a href="https://github.com/vitest-dev/vitest/commits/v3.1.1/packages/vitest">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…mbdas (#4515) Bumps [eslint-plugin-prettier](https://github.com/prettier/eslint-plugin-prettier) from 5.2.3 to 5.2.5. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/prettier/eslint-plugin-prettier/releases">eslint-plugin-prettier's releases</a>.</em></p> <blockquote> <h2>v5.2.5</h2> <h3>Patch Changes</h3> <ul> <li><a href="https://redirect.github.com/prettier/eslint-plugin-prettier/pull/721">#721</a> <a href="https://github.com/prettier/eslint-plugin-prettier/commit/4f5513de4ce919c607773fd35d833117a8d8b676"><code>4f5513d</code></a> Thanks <a href="https://github.com/JounQin"><code>@JounQin</code></a>! - fix: clarify correct <code>eslint-config-prettier</code> peer range</li> </ul> <h2>v5.2.4</h2> <h3>Patch Changes</h3> <ul> <li><a href="https://redirect.github.com/prettier/eslint-plugin-prettier/pull/715">#715</a> <a href="https://github.com/prettier/eslint-plugin-prettier/commit/b8cfe56e345a9cd0f0160da91d99b8ee9e37c67e"><code>b8cfe56</code></a> Thanks <a href="https://github.com/JounQin"><code>@JounQin</code></a>! - chore: hourcekeeping, bump all (dev) deps</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/prettier/eslint-plugin-prettier/blob/main/CHANGELOG.md">eslint-plugin-prettier's changelog</a>.</em></p> <blockquote> <h2>5.2.5</h2> <h3>Patch Changes</h3> <ul> <li><a href="https://redirect.github.com/prettier/eslint-plugin-prettier/pull/721">#721</a> <a href="https://github.com/prettier/eslint-plugin-prettier/commit/4f5513de4ce919c607773fd35d833117a8d8b676"><code>4f5513d</code></a> Thanks <a href="https://github.com/JounQin"><code>@JounQin</code></a>! - fix: clarify correct <code>eslint-config-prettier</code> peer range</li> </ul> <h2>5.2.4</h2> <h3>Patch Changes</h3> <ul> <li><a href="https://redirect.github.com/prettier/eslint-plugin-prettier/pull/715">#715</a> <a href="https://github.com/prettier/eslint-plugin-prettier/commit/b8cfe56e345a9cd0f0160da91d99b8ee9e37c67e"><code>b8cfe56</code></a> Thanks <a href="https://github.com/JounQin"><code>@JounQin</code></a>! - chore: hourcekeeping, bump all (dev) deps</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/prettier/eslint-plugin-prettier/commit/b2e195c7f32aef30363655b92c0f44b7453a25c2"><code>b2e195c</code></a> chore: release eslint-plugin-prettier (<a href="https://redirect.github.com/prettier/eslint-plugin-prettier/issues/722">#722</a>)</li> <li><a href="https://github.com/prettier/eslint-plugin-prettier/commit/4f5513de4ce919c607773fd35d833117a8d8b676"><code>4f5513d</code></a> fix: clarify correct <code>eslint-config-prettier</code> peer range (<a href="https://redirect.github.com/prettier/eslint-plugin-prettier/issues/721">#721</a>)</li> <li><a href="https://github.com/prettier/eslint-plugin-prettier/commit/022254164f6f2727434f463dbb598a230d0d8807"><code>0222541</code></a> chore(deps): pin dependencies (<a href="https://redirect.github.com/prettier/eslint-plugin-prettier/issues/720">#720</a>)</li> <li><a href="https://github.com/prettier/eslint-plugin-prettier/commit/9f0ba209ab55b0ecaf955c6e593e11cff986e42e"><code>9f0ba20</code></a> chore: add renovate preset</li> <li><a href="https://github.com/prettier/eslint-plugin-prettier/commit/d670ebbba434b97c63a99598e5baa072dc6751b6"><code>d670ebb</code></a> chore: fix release script</li> <li><a href="https://github.com/prettier/eslint-plugin-prettier/commit/0e123363095357c469e6f04324db8dd55a6e18dc"><code>0e12336</code></a> chore: release eslint-plugin-prettier (<a href="https://redirect.github.com/prettier/eslint-plugin-prettier/issues/716">#716</a>)</li> <li><a href="https://github.com/prettier/eslint-plugin-prettier/commit/b8cfe56e345a9cd0f0160da91d99b8ee9e37c67e"><code>b8cfe56</code></a> chore: hourcekeeping, bump all (dev) deps (<a href="https://redirect.github.com/prettier/eslint-plugin-prettier/issues/715">#715</a>)</li> <li><a href="https://github.com/prettier/eslint-plugin-prettier/commit/ca5eb3ec11c4ae511e1da22736c73b253210b73b"><code>ca5eb3e</code></a> test: improve how to get <code>FlatESLint</code> (<a href="https://redirect.github.com/prettier/eslint-plugin-prettier/issues/713">#713</a>)</li> <li><a href="https://github.com/prettier/eslint-plugin-prettier/commit/6f35f1ba6b2b52dfb012dee686cf14932fe892c3"><code>6f35f1b</code></a> chore(housekeeping): update ESLint to v9 (<a href="https://redirect.github.com/prettier/eslint-plugin-prettier/issues/709">#709</a>)</li> <li><a href="https://github.com/prettier/eslint-plugin-prettier/commit/9726349ca4209a8c83b4e54656825dd0ac17d956"><code>9726349</code></a> chore: rename default branch to <code>main</code> (<a href="https://redirect.github.com/prettier/eslint-plugin-prettier/issues/710">#710</a>)</li> <li>See full diff in <a href="https://github.com/prettier/eslint-plugin-prettier/compare/v5.2.3...v5.2.5">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
🤖 I have created a release *beep* *boop* --- ## [6.4.2](v6.4.1...v6.4.2) (2025-03-31) ### Bug Fixes * **lambda:** bump @octokit/webhooks from 13.7.5 to 13.8.0 in /lambdas in the octokit group ([#4514](#4514)) ([1f1da77](1f1da77)) * **lambda:** bump the aws group in /lambdas with 3 updates ([#4513](#4513)) ([ecf9a77](ecf9a77)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
|
Updated:
Some more todo work on my list
@dgokcin thanks for already having a look. Would you have time to review the PR once I done with the draft. Early feedback is always welcome. |
|
@dgokcin would you have time to test hte PR? |
can try it on monday :) |
There was a problem hiding this comment.
Copilot reviewed 19 out of 30 changed files in this pull request and generated no comments.
Files not reviewed (11)
- examples/default/.terraform.lock.hcl: Language not supported
- examples/default/main.tf: Language not supported
- examples/default/outputs.tf: Language not supported
- examples/multi-runner/main.tf: Language not supported
- examples/multi-runner/outputs.tf: Language not supported
- examples/prebuilt/main.tf: Language not supported
- main.tf: Language not supported
- modules/multi-runner/outputs.tf: Language not supported
- modules/multi-runner/runners.tf: Language not supported
- modules/multi-runner/variables.tf: Language not supported
- modules/runners/main.tf: Language not supported
Comments suppressed due to low confidence (3)
modules/runners/README.md:136
- [nitpick] Consider shortening and streamlining the description for the 'ami' input to ensure clarity and to align with the format used in other configuration inputs.
| <a name="input_ami"></a> [ami](#input_ami) | AMI configuration for the action runner instances. This object allows you to specify all AMI-related settings in one place. ... |
README.md:117
- [nitpick] Ensure that the deprecated variable names and their replacement counterparts are consistently formatted and clearly distinguishable to avoid any confusion for module users.
| <a name="input_ami_id_ssm_parameter_name"></a> [ami_id_ssm_parameter_name](#input_ami_id_ssm_parameter_name) | [DEPRECATED: Use ami.id_ssm_parameter_name] String used to construct the SSM parameter name ... |
examples/multi-runner/templates/runner-configs/linux-x64-ubuntu.yaml:25
- [nitpick] Consider adding an inline comment within the ami block to indicate that this is the new consolidated AMI configuration replacing the deprecated variables.
ami:
npalm
requested review from
dgokcin,
Copilot and
koendelaat
and removed request for
dgokcin
There was a problem hiding this comment.
Copilot reviewed 19 out of 30 changed files in this pull request and generated no comments.
Files not reviewed (11)
- examples/default/.terraform.lock.hcl: Language not supported
- examples/default/main.tf: Language not supported
- examples/default/outputs.tf: Language not supported
- examples/multi-runner/main.tf: Language not supported
- examples/multi-runner/outputs.tf: Language not supported
- examples/prebuilt/main.tf: Language not supported
- main.tf: Language not supported
- modules/multi-runner/outputs.tf: Language not supported
- modules/multi-runner/runners.tf: Language not supported
- modules/multi-runner/variables.tf: Language not supported
- modules/runners/main.tf: Language not supported
Comments suppressed due to low confidence (3)
README.md:121
- Typo detected: 'optiona' should be corrected to 'optional'.
| <a name="input_aws_partition"></a> [aws_partition](#input_aws_partition) | (optiona) partition in the arn namespace to use if not 'aws' | `string` | "aws" | no |
modules/multi-runner/README.md:78
- Typo detected: 'avaialbe' should be corrected to 'available'.
… JIT config API is avaialbe. In case you upgradeing from 3.x to 4.x you can set `enable_jit_config` to `false` …
modules/multi-runner/README.md:78
- Typo detected: 'upgradeing' should be corrected to 'upgrading'.
… JIT config API is avaialbe. In case you upgradeing from 3.x to 4.x you can set `enable_jit_config` to `false` …
koendelaat
approved these changes
Apr 7, 2025
did you had time to run a quikc check? |
|
super busy day ay work wanna review all the files will look ASAP |
dgokcin
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR migrates the launch template to use SSM to foor looking up AMI ID. This PR is inteded to migrate to use SSM for AMI lookups. In later PR we will remove logic from scale-up and remove old parateters.
By default, the module still uses the same AMI filters, but difference is the resulting AMI ID is stored in SSM instead of the launch template. As alternative the module user can provide
ami_id_ssm_parameter_arnpointing to an SSM parameter containing the AMI ID to be used (data type aws:ec2:image).When using a custom managed AMI this will avoid drift in terraform when
ami.id_ssm_parameter_arnis used instead of the deprecatedami_id_ssm_parameter_name. Another way to avoid the drift is to ensure the filter is poiting to the same image. See also #4460In PR #4488 and updater via Lambda is introduced. I think we should firt think how we can better support the AMI id in the core. What this PR is supposed todo. NExt the update can be an nice way to auto update AMI's without running terraform.
The PR also refactor the variables for
ami_*and move the to a dedicated objectami. The old ones remains till the next major release. Deprecattion warnings are added to the output.Notes
Fix