refactor: Update acceptance rate calculation in MetricsViewer.vue

github-copilot-resources · May 31, 2024 · fb4e70f · fb4e70f
1 parent ea11d05
commit fb4e70f
Showing 1 changed file with 7 additions and 5 deletions.
diff --git a/src/components/MetricsViewer.vue b/src/components/MetricsViewer.vue
@@ -252,11 +252,9 @@ export default defineComponent({
         }
       ]
     };
-
-    let sum = 0;
+    
     const acceptanceRates = data.map((m: Metrics) => {
       const rate = m.total_lines_suggested !== 0 ? (m.total_lines_accepted / m.total_lines_suggested) * 100 : 0;
-      sum += rate;
       return rate;
     });
     
@@ -274,8 +272,12 @@ export default defineComponent({
         }
       ]
     };
-
-    acceptanceRateAverage.value = cumulativeNumberAcceptances.value / cumulativeNumberSuggestions.value * 100;
+    
+    if(cumulativeNumberSuggestions.value === 0){
+      acceptanceRateAverage.value = 0;
+    } else {
+      acceptanceRateAverage.value = cumulativeNumberAcceptances.value / cumulativeNumberSuggestions.value * 100;
+    }
 
     totalActiveUsersChartData.value = {
       labels: data.map((m: Metrics) => m.day),