Merge pull request #18072 from github/revert-18009-calumgrant/bmn/rec…

…ord-build-mode Revert "C++: Implement compilation_build_mode"
github · Nov 22, 2024 · cdfb085 · cdfb085
2 parents ab9a2bd + 169671a
commit cdfb085
Show file tree

Hide file tree

Showing 9 changed files with 1,286 additions and 10,697 deletions.
diff --git a/cpp/downgrades/f0156f5f88ab5967c79162012c20f30600ca5ebf/old.dbscheme b/cpp/downgrades/f0156f5f88ab5967c79162012c20f30600ca5ebf/old.dbscheme
diff --git a/cpp/downgrades/f0156f5f88ab5967c79162012c20f30600ca5ebf/semmlecode.cpp.dbscheme b/cpp/downgrades/f0156f5f88ab5967c79162012c20f30600ca5ebf/semmlecode.cpp.dbscheme
diff --git a/cpp/downgrades/f0156f5f88ab5967c79162012c20f30600ca5ebf/upgrade.properties b/cpp/downgrades/f0156f5f88ab5967c79162012c20f30600ca5ebf/upgrade.properties
diff --git a/cpp/ql/lib/semmle/code/cpp/Compilation.qll b/cpp/ql/lib/semmle/code/cpp/Compilation.qll
@@ -112,7 +112,4 @@ class Compilation extends @compilation {
    * termination, but crashing due to something like a segfault is not.
    */
   predicate normalTermination() { compilation_finished(this, _, _) }
-
-  /** Holds if this compilation was compiled using the "none" build mode. */
-  predicate buildModeNone() { compilation_build_mode(this, 0) }
 }
diff --git a/cpp/ql/lib/semmlecode.cpp.dbscheme b/cpp/ql/lib/semmlecode.cpp.dbscheme
@@ -46,22 +46,6 @@ compilation_args(
     string arg : string ref
 );
 
-/**
- * Optionally, record the build mode for each compilation.
- */
-compilation_build_mode(
-    unique int id : @compilation ref,
-    int mode : int ref
-);
-
-/*
-case @compilation_build_mode.mode of
-  0 = @build_mode_none
-| 1 = @build_mode_manual
-| 2 = @build_mode_auto
-;
-*/
-
 /**
  * The source files that are compiled by a compiler invocation.
  * If `id` is for the compiler invocation