Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Add more CommandExecutionFunctions #18093

Merged

Conversation

MathiasVP
Copy link
Contributor

Just a list of command execution functions from the Win32 that I was researching for something else. May as well include them as CommandExecutionFunctions while here.

@MathiasVP MathiasVP requested a review from a team as a code owner November 25, 2024 13:45
@github-actions github-actions bot added the C++ label Nov 25, 2024
@MathiasVP MathiasVP added the no-change-note-required This PR does not need a change note label Nov 25, 2024
Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question. Otherwise LGTM provided DCA is ok.

Copy link
Contributor

@jketema jketema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming DCA is ok.

@MathiasVP
Copy link
Contributor Author

DCA was uneventful

@MathiasVP MathiasVP merged commit 8fd581d into github:main Nov 25, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C++ no-change-note-required This PR does not need a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants