Remove pull request template #18104
Open
Remove pull request template #18104
+30
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace with an updated check-change-note.yml workflow. Add a comment whenever a pull request has changes that may need to be tested in autofix. Also, remove parts of the checklist that are not related to autofix.
|
The new workflow job won't run until this PR is merged since it runs under |
esbena
requested changes
Nov 25, 2024
| - "!**/experimental/**" | ||
| - "!ql/**" | ||
| - "!rust/**" | ||
| - ".github/workflows/check-change-note.yml" | ||
|
|
||
| jobs: | ||
| add-pr-reminders: | ||
| env: | ||
| REPO: ${{ github.repository }} |
There was a problem hiding this comment.
Suggested change
| REPO: ${{ github.repository }} |
https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/store-information-in-variables#default-environment-variables
explains GITHUB_REPOSITORY as
The owner and repository name. For example, octocat/Hello-World.
So we can skip declaring our own variable here.
There was a problem hiding this comment.
I was just following along with REPO elsewhere in the file. Looking in history, I see that REPO was added 13 months ago...by you. 😄
Is there a reason to change it in this job, but not the other?
|
|
||
| - name: Check if the 'reminders' comment exists | ||
| run: | | ||
| reminder_comment=$(gh api "repos/$REPO/issues/$PULL_REQUEST_NUMBER/comments" --jq '.[] | select(.body | test("### Pull Request reminders for autofix"))') |
There was a problem hiding this comment.
Suggested change
| reminder_comment=$(gh api "repos/$REPO/issues/$PULL_REQUEST_NUMBER/comments" --jq '.[] | select(.body | test("### Pull Request reminders for autofix"))') | |
| reminder_comment=$(gh api "repos/$GITHUB_REPOSITORY/issues/$PULL_REQUEST_NUMBER/comments" --jq '.[] | select(.body | test("### Pull Request reminders for autofix"))') |
| echo "The reminder comment does not exist. Adding it." | ||
| comment_body="$(cat .github/pr-comment-reminder.md)" | ||
|
|
||
| gh api "repos/$REPO/issues/$PULL_REQUEST_NUMBER/comments" -f body="$comment_body" |
There was a problem hiding this comment.
Suggested change
| gh api "repos/$REPO/issues/$PULL_REQUEST_NUMBER/comments" -f body="$comment_body" | |
| gh api "repos/$GITHUB_REPOSITORY/issues/$PULL_REQUEST_NUMBER/comments" -f body="$comment_body" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace with an updated check-change-note.yml workflow.
Add a comment whenever a pull request has changes that may need to be tested in autofix. Also, remove parts of the checklist that are not related to autofix.