Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C++: Support if consteval and if ! consteval #18502

Merged
merged 8 commits into from
Jan 20, 2025
Merged

C++: Support if consteval and if ! consteval #18502

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
84c674b
C++: Fix typos in IR translation comments
jketema Jan 15, 2025
bc2f203
C++: Support `if consteval` and `if ! consteval`
jketema Jan 15, 2025
123f1d5
C++: Add upgrade and downgrade scripts
jketema Jan 15, 2025
4a3350b
C++: Update stats file
jketema Jan 15, 2025
6ad342c
C++: Add change note
jketema Jan 16, 2025
378f036
Update cpp/downgrades/1aa71a4a687fc93f807d4dfeeef70feceeced242/stmts.ql
jketema Jan 20, 2025
a74189f
Update cpp/ql/lib/change-notes/2024-01-16-consteval-if.md
jketema Jan 20, 2025
a9e0f20
C++: Simplify consteval if to be just a single class with an `isNot` …
jketema Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
C++: Fix typos in IR translation comments
  • Loading branch information
@jketema
jketema committed Jan 15, 2025
commit 84c674b992dfaab6d6cf857087385a4d145ceabf
2 changes: 1 addition & 1 deletion cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedCondition.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ abstract class TranslatedFlexibleCondition extends TranslatedCondition, Conditio
{
TranslatedFlexibleCondition() { this = TTranslatedFlexibleCondition(expr) }

final override predicate handlesDestructorsExplicitly() { none() } // TODO: this needs to be revisted when we get unnamed destructors
final override predicate handlesDestructorsExplicitly() { none() } // TODO: this needs to be revisited when we get unnamed destructors

final override TranslatedElement getChild(int id) { id = 0 and result = this.getOperand() }

Expand Down
2 changes: 1 addition & 1 deletion cpp/ql/lib/semmle/code/cpp/ir/implementation/raw/internal/TranslatedElement.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ private predicate ignoreExpr(Expr expr) {
}

/**
* Holds if the side effects of `expr` should be ignoredf for the purposes of IR generation.
* Holds if the side effects of `expr` should be ignored for the purposes of IR generation.
*
* In cases involving `constexpr`, a call can wind up as a constant expression. `ignoreExpr()` will
* not hold for such a call, since we do need to translate the call (as a constant), but we need to
Expand Down