Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling two-factor authentication documentation update #34830

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+2 −2
Open

Disabling two-factor authentication documentation update #34830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
493cd58
Add files via upload
georgethemarmot Oct 4, 2024
b33fa25
Update disabling-two-factor-authentication-for-your-personal-account.md
georgethemarmot Oct 4, 2024
aba9d5f
Merge branch 'main' into main
georgethemarmot Oct 4, 2024
fc59879
Merge branch 'main' into main
georgethemarmot Oct 15, 2024
e1e37ad
Merge branch 'main' into main
heiskr Nov 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified assets/images/help/2fa/disable-two-factor-authentication.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
4 changes: 2 additions & 2 deletions ...entication-2fa/disabling-two-factor-authentication-for-your-personal-account.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,10 +37,10 @@

{% data reusables.user-settings.access_settings %}
{% data reusables.user-settings.security %}
{% ifversion 2fa-reconfiguration-inline-update %}

Check warning on line 40 in content/authentication/securing-your-account-with-two-factor-authentication-2fa/disabling-two-factor-authentication-for-your-personal-account.md

View workflow job for this annotation

GitHub Actions / lint-content

Liquid `ifversion` (and `elsif`) should not always be true 

The Liquid ifversion condition '2fa-reconfiguration-inline-update' includes all possible versions and will always be true.
1. Hover over **Enabled**, then click **Disable**.
1. Click on the three dots option menu, then click **Disable two-factor authentication**.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
1. Click on the three dots option menu, then click **Disable two-factor authentication**.
1. Click {% octicon "kebab-horizontal" aria-label="The horizontal kebab icon" %}, then select **Disable two-factor authentication**.

Context in https://docs.github.com/en/contributing/style-guide-and-content-model/style-guide#lists-and-list-items and https://docs.github.com/en/contributing/style-guide-and-content-model/style-guide#use-clear-consistent-symbols-and-labels


![Screenshot of an account's 2FA settings. A green button labeled "Enabled" is outlined in orange.](/assets/images/help/2fa/disable-two-factor-authentication.png)
![Screenshot of an account's 2FA settings. The option menu is outlined in red.](/assets/images/help/2fa/disable-two-factor-authentication.png)
nguyenalex836 marked this conversation as resolved.
Show resolved Hide resolved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
![Screenshot of an account's 2FA settings. The option menu is outlined in red.](/assets/images/help/2fa/disable-two-factor-authentication.png)
![Screenshot of an account's 2FA settings. The ellipsis button (three dots) is highlighted with a dark orange outline.](/assets/images/help/2fa/disable-two-factor-authentication.png)

Context in https://docs.github.com/en/contributing/writing-for-github-docs/creating-screenshots


1. If necessary, enter your password or perform 2FA once more to disable 2FA for your {% data variables.product.prodname_dotcom %} account.
{% else %}
Expand Down
Loading