Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix note display rendering #35412

Merged
merged 2 commits into from
Nov 25, 2024

Conversation

akordowski
Copy link
Contributor

@akordowski akordowski commented Nov 25, 2024

Why:

The reusable data is rendered incorrectly in this article.

grafik

Closes: none

What's being changed (if available, include any code snippets, screenshots, or gifs):

This PR fixes the indentation of the if/else statements in the reusable data file. This fixes the rendering as you can see here.

grafik

Check off the following:

  • I have reviewed my changes in staging, available via the View deployment link in this PR's timeline (this link will be available after opening the PR).

    • For content changes, you will also see an automatically generated comment with links directly to pages you've modified. The comment won't appear if your PR only edits files in the data directory.
  • For content changes, I have completed the self-review checklist.

@github-actions github-actions bot added the triage Do not begin working on this issue until triaged by the team label Nov 25, 2024
@akordowski akordowski marked this pull request as ready for review November 25, 2024 08:15
@nguyenalex836 nguyenalex836 added content This issue or pull request belongs to the Docs Content team and removed triage Do not begin working on this issue until triaged by the team labels Nov 25, 2024
@nguyenalex836 nguyenalex836 added this pull request to the merge queue Nov 25, 2024
Merged via the queue into github:main with commit 5cbec43 Nov 25, 2024
53 checks passed
Copy link
Contributor

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues

@akordowski akordowski deleted the fix-note-display-rendering branch November 26, 2024 06:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
content This issue or pull request belongs to the Docs Content team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants