-
Notifications
You must be signed in to change notification settings - Fork 61.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use correct description of detaching a fork #37296
Conversation
Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines. |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksThe table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
Thanks so much for opening a PR! I'll get this triaged for review |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
Thanks so much for opening a PR with this fix! I'll update the branch and get this merged once tests are passing 🍏 |
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
Why:
When I was looking at detaching a fork, I read these docs and when I came across the word "delete" here, I was concerned this might delete my fork instead of detaching it. I believe this part of the documentation was copied from the details about how to delete a repo (or manually detach, which includes deleting the repo), and changing this word was missed.
What's being changed (if available, include any code snippets, screenshots, or gifs):
In the section about automatically detaching a fork, I just changed "deleting" to "detaching", since the process described in this section does NOT delete the fork.
Check off the following: