Skip to content

Commit

Permalink
Merge pull request #302 from github/dependabot/bundler/rubocop-minite…
Browse files Browse the repository at this point in the history
…st-tw-0.34.5

Update rubocop-minitest requirement from ~> 0.28.0 to ~> 0.34.5
  • Loading branch information
ndonewar authored Mar 8, 2024
2 parents 29cc627 + e8b9fb8 commit 5c0f008
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ group :development do
gem "rake"
gem "rubocop", "~> 1.45.1"
gem "rubocop-github", "~> 0.20.0"
gem "rubocop-minitest", "~> 0.28.0"
gem "rubocop-minitest", "~> 0.34.5"
gem "rubocop-performance", "~> 1.19.1"
gem "rubocop-rake", "~> 0.6.0"
gem "simplecov", require: false
Expand Down
2 changes: 1 addition & 1 deletion test/client/cluster_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
h = @cluster.pending_tasks

assert_equal %w[tasks], h.keys.sort
assert h["tasks"].is_a?(Array), "the tasks lists is always an Array even if empty"
assert_kind_of Array, h["tasks"], "the tasks lists is always an Array even if empty"
end

it "returns the list of indices in the cluster" do
Expand Down
2 changes: 1 addition & 1 deletion test/client/docs_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -421,7 +421,7 @@

assert h.key?("nodes"), "response contains \"nodes\" information"
assert h.key?("shards"), "response contains \"shards\" information"
assert h["shards"].is_a?(Array), "\"shards\" is an array"
assert_kind_of Array, h["shards"], "\"shards\" is an array"
end

it "generates QueryParsingError exceptions on bad input when searching" do
Expand Down
4 changes: 2 additions & 2 deletions test/client/tasks_test.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,11 +18,11 @@
it "list all in-flight tasks" do
h = @tasks.get

assert h["nodes"].keys.size > 0
assert_operator h["nodes"].keys.size, :>, 0

total_tasks = h["nodes"].map { |k, v| v["tasks"].keys.count }.sum

assert total_tasks > 0
assert_operator total_tasks, :>, 0
end

it "groups by parent->child relationships when get-all tasks API is grouped by 'parents'" do
Expand Down

0 comments on commit 5c0f008

Please sign in to comment.