Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added AWS bucket as a secret #1266

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Added AWS bucket as a secret #1266

merged 3 commits into from
Sep 20, 2024

Conversation

begonaguereca
Copy link
Collaborator

@begonaguereca begonaguereca commented Sep 20, 2024 •
edited
Loading

Added our new AWS bucket as an action secret.

  • Did you write/update appropriate tests
  • Release notes updated (if appropriate)
  • Appropriate logging output
  • Issue linked
  • Docs updated (or issue created)
  • New package licenses are added to ThirdPartyNotices.txt (if applicable)

@github-actions GitHub Actions
Copy link

Unit Test Results

0 tests   0 ✅  0s ⏱️
0 suites  0 💤
0 files    0 ❌

Results for commit b53904f.

@begonaguereca begonaguereca marked this pull request as ready for review September 20, 2024 23:01
brianaj
brianaj approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@brianaj brianaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

ArinGhazarian
ArinGhazarian approved these changes Sep 20, 2024
View reviewed changes
Copy link
Collaborator

@ArinGhazarian ArinGhazarian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@begonaguereca begonaguereca merged commit 538b267 into main Sep 20, 2024
29 checks passed
@begonaguereca begonaguereca deleted the aws-bucket branch September 20, 2024 23:22
@github-actions GitHub Actions
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
bbs2gh 78% 73% 651 ✔
ado2gh 84% 78% 627 ✔
Octoshift 87% 76% 1272 ✔
gei 79% 70% 519 ✔
Summary 83% (6821 / 8172) 75% (1534 / 2044) 3069 ✔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brianaj brianaj brianaj approved these changes

@ArinGhazarian ArinGhazarian ArinGhazarian approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@begonaguereca @brianaj @ArinGhazarian