Getting CLI working again #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unit Test Results811 tests 811 ✅ 22s ⏱️ Results for commit b77dbf2. ♻️ This comment has been updated with latest results. |
ArinGhazarian
requested changes
Sep 27, 2024
6 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🟢 🟢 🟢
We have a couple of changes that happened in order to make this PR work:
https://github.com/enterprises/fabrikam/sso
OnePass has been updated ✅
Since we moved over to the new EMU org, there are lots of other existing "groups" there, so we had to fix a pagination bug. The issue was addressed in this PR and the changes were pulled into this branch.
Dynamically naming the BBS tests fixes the following error:
My recommendation is that we move forward for now, catch the CI tests at the right time and let the Git systems team address that bug.
Closes: https://github.ghe.com/github/octoshift/issues/9379
Closes: https://github.ghe.com/github/octoshift/issues/9347
Closes: https://github.ghe.com/github/octoshift/issues/9373
Closes: https://github.ghe.com/github/octoshift/issues/9378