Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nodejs.yml #23

Merged
merged 1 commit into from
Aug 25, 2023
Merged

Update nodejs.yml #23

merged 1 commit into from
Aug 25, 2023

Conversation

manuelpuyol
Copy link
Contributor

No description provided.

@manuelpuyol manuelpuyol requested a review from a team as a code owner August 25, 2023 19:47
dgreif
dgreif approved these changes Aug 25, 2023
View reviewed changes
Copy link
Contributor

@dgreif dgreif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I'm also fine with going to 18 if you want to get on LTS

@manuelpuyol manuelpuyol merged commit b47bc5d into master Aug 25, 2023
1 check passed
@manuelpuyol manuelpuyol deleted the manuelpuyol-patch-1 branch August 25, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dgreif dgreif dgreif approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manuelpuyol @dgreif