-
Notifications
You must be signed in to change notification settings - Fork 277
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Misc fixes to the training scripts #400
base: main
Are you sure you want to change the base?
Conversation
jessehouwing
commented
May 17, 2023
•
edited
Loading
edited
- Doesn't make repos private (cause private repos can't use Pages and Advanced Security and other potentially interesting repos)
- Increases wait times to prevent secondary rate limits
- Fixes python ssl error by downgrading urllib3 to v2.
- Removes github project creation, cause it's broken. Needs to be replaced with Projects V2 at some point.
- Fixing for New Computers #394 Automatically imports bash env variables
- Changes ubuntu to jammy.
@jessehouwing, I merged my fix for #394 into this branch now that @parkerbxyz got me approved. I see that #390 looks like it fixes upgrading projects to v2. I hadn't considered the impact of making projects private on .com. We've been teaching on GHES historically, so Pages still work. I also like the idea of adding in Advanced Security as a part of the class. There are a lot of possibilities there. |
@amyschoen We're teaching mostly through the GitHub Professional Services Partner Program and use the GitHub provided There is an admin class and a ghas class as well that already explains advanced security, but it's easier if the users are in a fully enabled public repo where a demo or answer to a question may lead to demoing these advanced features. |
Now that there is a |