New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: support discussion state types #827

Merged

setchy merged 10 commits into gitify-app:main from setchy:feature/discussion-state-types

Feb 29, 2024

Member

setchy commented Feb 26, 2024 •

edited

Loading

Closes: #813

Uses the GraphQL API to fetch the Discussion stateReason

setchy added 2 commits

February 26, 2024 09:17


          feat: support discussion states

fb397bd


          feat: support discussion states

c6414a3

setchy requested review from afonsojramos and bmulholland as code owners

February 26, 2024 14:38

setchy added the enhancement label

setchy marked this pull request as draft

February 26, 2024 14:41

setchy added 3 commits

February 26, 2024 10:17


          feat: add test coverage

a704180


          feat: add test coverage

c0e4705


          feat: add test coverage

ffec197

setchy marked this pull request as ready for review

February 26, 2024 15:36

Member Author

setchy commented Feb 26, 2024

In a separate PR, i think it would be wise to move all of this state enrichment logic out of hooks/useNotifications and into a separate file.

setchy added 2 commits

February 27, 2024 06:57


          refactor graphql search interface to be generic.

1beb3dc

add support for answered discussion


          add tests for answered discussion

b1d5b3a

bmulholland reviewed

View reviewed changes

src/hooks/useNotifications.test.ts Outdated Show resolved Hide resolved

bmulholland reviewed

View reviewed changes

src/typesGithub.ts Show resolved Hide resolved

bmulholland reviewed

View reviewed changes

src/hooks/useNotifications.ts Show resolved Hide resolved

bmulholland reviewed

View reviewed changes

src/hooks/useNotifications.ts Show resolved Hide resolved

bmulholland reviewed

View reviewed changes

src/utils/helpers.ts Show resolved Hide resolved

setchy added 2 commits

February 27, 2024 11:34


          refactor mocks out

11e777d


          refactor mocks out

22be07c

setchy requested a review from bmulholland

February 27, 2024 16:40


          Merge branch 'main' into feature/discussion-state-types

a02248d

bmulholland approved these changes

View reviewed changes

Collaborator

bmulholland left a comment

Good for now -- thanks for the followup ideas!

setchy merged commit 73d0077 into gitify-app:main

7 checks passed

setchy deleted the feature/discussion-state-types branch

February 29, 2024 16:39

adufr pushed a commit to adufr/gitify that referenced this pull request


          feat: support discussion state types (gitify-app#827)

2aebd86

* feat: support discussion states

* refactor graphql search interface to be generic.

* refactor mocks out

setchy added this to the Release 5.0.0 milestone

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels