-
Notifications
You must be signed in to change notification settings - Fork 421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added nginx config example to cut-off ".git" #173
base: master
Are you sure you want to change the base?
Conversation
server { | ||
listen *:80 default; | ||
location / { | ||
rewrite ^ https://git.example.com$request_uri? permanent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you document somewhere that people have to change this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for my English skills, but I don't understand the question.
Did you mean "why people have to change that"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At this point you have hardcoded the url https://git.example.com
people may not know that they have to change this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Can you show an example of the "documentation"? Should I just add a note in the first lines of this configuration file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xaionaro I guess @jvanbaarsen means something like this https://github.com/gitlabhq/gitlab-recipes/blob/master/web-server/nginx/gitlab-ssl#L31
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axilleas Yeah thanks :)
Should this go into the normal GitLab? |
I think having both features (cut of .git and /public as default start page when not logged in) as toggles would be great |
It's required to be able to clone with
instead of
as it already is on GitHub.