-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[Gitpod CLI] gp rebuild
improvements
#15740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
5 tasks
c3b6220
to
a3b8cdf
Compare
akosyakov
reviewed
Jan 14, 2023
akosyakov
reviewed
Jan 14, 2023
akosyakov
reviewed
Jan 14, 2023
akosyakov
reviewed
Jan 14, 2023
This comment was marked as resolved.
This comment was marked as resolved.
akosyakov
reviewed
Jan 16, 2023
akosyakov
reviewed
Jan 17, 2023
Co-authored-by: Victor Nogueira <[email protected]>
1a4c6f1
to
ea6960e
Compare
This comment was marked as resolved.
This comment was marked as resolved.
akosyakov
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code wise it seems to be alright, I have not tried
/hold
@andreafalzetti @felladrin please merge when you are sure
felladrin
approved these changes
Jan 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed and tested! ✅
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: gp cli
deployed: IDE
IDE change is running in production
deployed
Change is completely running in production
release-note-none
size/L
team: IDE
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Follow up PR of things we overlooked in the initial PR:
outcome
,.
won't work if the user is inside a sub-directory)docker run
should not be propagated outside of the container because it can be anything (e.g user typingexit 1
) which currently gets logged as an error fromgp rebuild
nil
error when there is not real errorRelated Issue(s)
Fixes #
How to test
Dockerfile
which usedCOPY
and relies on location, make sure files are copied correctly from the workspace checkout locationbash
installed (ie.busybox
)exit 1
to leave the containerRelease Notes
Documentation
Werft options:
If enabled this will build
install/preview
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh