Skip to content

Speed up edit-compile-run loop for workspace components #9569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 26, 2022
Merged

Conversation

Furisto
Copy link
Member

@Furisto Furisto commented Apr 26, 2022

Description

Speed up edit-compile-run loop for workspace components. Each workspace component has a script that will

  • Build a timestamped docker image for the component
  • Update the running instance with the new image
  • Set the change cause so that it can be easily identified in the rollout history
  • Wait for the rollout to finish
  • Enable debug logs

Related Issue(s)

n.a.

How to test

  • Open workspace
  • Execute one of the debug.sh scripts
  • The component will be build and the running instance in your namespace will be updated

Release Notes

None

@Furisto Furisto requested a review from a team April 26, 2022 20:22
@github-actions github-actions bot added the team: workspace Issue belongs to the Workspace team label Apr 26, 2022
Copy link
Contributor

@sagor999 sagor999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is awesome! thank you! ❤️ ❤️ 🦸

@roboquat roboquat merged commit 3914677 into main Apr 26, 2022
@roboquat roboquat deleted the fo/debug-sh branch April 26, 2022 22:14
@utam0k
Copy link
Contributor

utam0k commented Apr 26, 2022

Awesome ❤️

@jenting
Copy link
Contributor

jenting commented Apr 26, 2022

💯

@roboquat roboquat added deployed: workspace Workspace team change is running in production deployed Change is completely running in production labels Apr 27, 2022
@mteam88
Copy link

mteam88 commented May 3, 2022

@roboquat How do you run debug.sh? Is this for a gitpod user or a gitpod developer? Is there anything like this for developing dockerfiles?

@utam0k
Copy link
Contributor

utam0k commented May 9, 2022

@mteam88 Hi, these scripts were designed for the gitpod developers.

@mteam88
Copy link

mteam88 commented May 9, 2022

@utam0k Ok then. Any way currently to simulate the build process that occurs when starting a workspace so one doesn't have to create a new workspace after every change to a .gitpod.Dockerfile?

@utam0k
Copy link
Contributor

utam0k commented May 9, 2022

@mteam88 Good question! Thank you. But there is no such thing as far as I know. Maybe these documents will help you.

@mteam88
Copy link

mteam88 commented May 9, 2022

@utam0k Checked those out.
This sequence here:

docker build -f .gitpod.Dockerfile -t gitpod-dockerfile-test .
docker run -it gitpod-dockerfile-test bash

Is sorta useful, and is essentially what I have been doing, but it does not completely simulate starting a workspace. My project (based on the workspace-vnc-full gitpod image) requires that. Rather annoying to start a whole new workspace. And recently I have had problems with that build system link to discord issue

@utam0k
Copy link
Contributor

utam0k commented May 9, 2022

@mteam88 Nice idea. I missed your discord question. If you want, you can create the issue with the minimal reproduction method you found.

@mteam88
Copy link

mteam88 commented May 9, 2022

@utam0k Will do. Thanks for all your help!

@mteam88
Copy link

mteam88 commented May 9, 2022

@utam0k Here is the issue if you wanna show some support. #9865

@utam0k
Copy link
Contributor

utam0k commented May 9, 2022

@mteam88 Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployed: workspace Workspace team change is running in production deployed Change is completely running in production release-note-none size/L team: workspace Issue belongs to the Workspace team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants