adding tests to utils.py #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gonmeso
reviewed
Apr 25, 2024
tests/test_utils.py
Outdated
|
|
||
|
|
||
| @mock.patch("builtins.open") | ||
| @mock.patch("json.load", mock.MagicMock(side_effect=[{"test": "test"}])) |
There was a problem hiding this comment.
MagicMock is automatically used by patch, just add directly the side effect:
@mock.patch("json.load", side_effect=[{"test": "test"}])
Gonmeso
requested changes
Apr 25, 2024
Gonmeso
reviewed
Apr 25, 2024
tests/test_utils.py
Outdated
| """ | ||
| Tests when the JSON file is not found. | ||
| """ | ||
| with TestCase.assertRaises(TestCase, FileNotFoundError): |
There was a problem hiding this comment.
Please use pytest.raises (docs):
with pytest.raises(FileNotFoundError):
...If you could also make this change for line 67 it will be greatly appreciated
added 2 commits
April 25, 2024 09:34
|
@stevencartavia CI is failing, please check the errors and fix them |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added tests for the read_json function from the utils.py file.