integrations compatible with agent #57
Conversation
…are no integrations and only contracts
examples/uni_v3_lp/action_agent.py
Outdated
| chain=chain, | ||
| integrations=["UniswapV3"], | ||
| id=id, | ||
| chain="ethereum:sepolia:https://sepolia.infura.io/v3/765888cfa824440c8c0feb5b492abedd", |
There was a problem hiding this comment.
Remove the URL as it might be a private RPC node
| self.chain = chain | ||
| self.account = account | ||
| self._check_passphrase_in_env() | ||
| self._check_or_create_account() | ||
| self.contract_handler = ContractHandler(contracts, integrations) |
There was a problem hiding this comment.
Add an if statement so if contracts and integrations are both None a error is raised
giza/agents/agent.py
Outdated
| duplicates = set(contract_names) & set(integrations) | ||
| if duplicates: | ||
| duplicate_names = ", ".join(duplicates) | ||
| raise ValueError( |
There was a problem hiding this comment.
For future reference, lets create a custom exception for this
| @staticmethod | ||
| def from_name(name: str, sender: AccountAPI) -> uniswap_module.Uniswap: | ||
| match name: | ||
| case "UniswapV3": |
There was a problem hiding this comment.
I think that it would be better to have an enum for this, maybe open an issue and will deal with this later
| amount1Desired: int, | ||
| amount0Min: int = 0, | ||
| amount1Min: int = 0, | ||
| deadline: int = None, |
There was a problem hiding this comment.
deadline: int | None = None
| from giza.agents.integrations.uniswap.pool import Pool | ||
|
|
||
|
|
||
| class PoolFactory: |
| from ape.contracts import ContractInstance | ||
|
|
||
|
|
||
| class Quoter: |
There was a problem hiding this comment.
Docstrings, None type hints and logging
| from giza.agents.integrations.uniswap.router import Router | ||
|
|
||
|
|
||
| class Uniswap: |
There was a problem hiding this comment.
Docstrings, typhints and logging
There was a problem hiding this comment.
Missing docstrings and typehints, for utils no logging is needed if you feel like it
giza/agents/integration.py
Outdated
| @@ -0,0 +1,13 @@ | |||
| from ape.api import AccountAPI | |||
|
|
|||
| import giza.agents.integrations.uniswap.uniswap as uniswap_module | |||
There was a problem hiding this comment.
Create an __init__.py inside integrations which imports Uniswap class.
__init__.py
from import giza.agents.integrations.uniswap.uniswap import Uniswap
__all__ = ["Uniswap"]New import:
from giza.agents.integrations import UniswapAnother suggestion could be to call all the integration where the main integration is with a common name like core.py or integration_handler.py so all the new integrations could be referenced the same way
from giza.agents.integrations.uniswap.core import UniswapV3
from giza.agents.integrations.enzyme.core import Enzyme…ract names, assets included in toml file, fixed typing
Agents can accept protocol integrations as input. The contracts parameter is now optional.