fix abs

gizatechxyz · Oct 8, 2024 · 9a2db04 · 9a2db04
1 parent 96bfa1c
commit 9a2db04
Showing 1 changed file with 10 additions and 2 deletions.
diff --git a/packages/numbers/src/f64/ops.cairo b/packages/numbers/src/f64/ops.cairo
@@ -8,8 +8,8 @@ pub(crate) fn abs(a: F64) -> F64 {
         return F64 { d: NaN };
     }
 
-    if a.d <= 0 {
-        F64 { d: a.d * ONE }
+    if a.d < 0 {
+        F64 { d: -a.d }
     } else {
         a
     }
@@ -418,6 +418,14 @@ mod tests {
         assert(exp2(a).d == 72057594037927936, 'invalid exp2 of 2');
     }
 
+    #[test]
+    #[available_gas(400000)]
+    fn test_exp2_neg() {
+        let a: F64 = FixedTrait::new(-925062941);
+        println!("A: {:}", exp2(a).d);
+        assert(exp2(a).d == -6835341966, 'invalid exp2 of 2');
+    }
+
     #[test]
     #[available_gas(20000)]
     fn test_exp2_int() {