Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add sign #226

Merged
merged 3 commits into from
Oct 6, 2023
Merged

feat: add sign #226

merged 3 commits into from
Oct 6, 2023

Conversation

0xd3bs
Copy link
Contributor

@0xd3bs 0xd3bs commented Oct 4, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: 224

What is the new behavior?

  • Orion Lib: Operators: Sign

Does this introduce a breaking change?

  • Yes
  • No

Other information

raphaelDkhn
raphaelDkhn approved these changes Oct 6, 2023
View reviewed changes
Copy link
Collaborator

@raphaelDkhn raphaelDkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@raphaelDkhn raphaelDkhn merged commit 660d4bb into gizatechxyz:develop Oct 6, 2023
1 check passed
@0xd3bs 0xd3bs deleted the feat/add-sign branch October 10, 2023 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelDkhn raphaelDkhn raphaelDkhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xd3bs @raphaelDkhn