Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/where #407

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Feat/where #407

merged 9 commits into from
Oct 26, 2023

Conversation

TsBauer
Copy link
Contributor

@TsBauer TsBauer commented Oct 26, 2023

Pull Request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build-related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #369

What is the new behavior?

  • Where operator

Does this introduce a breaking change?

  • Yes
  • No

Other information

@TsBauer TsBauer changed the base branch from main to develop October 26, 2023 07:11
@TsBauer
Copy link
Contributor Author

TsBauer commented Oct 26, 2023 •
edited
Loading

I think I've made a mistake by rebasing from main instead of develop. Do you need me to fix that? Sorry for the inconvenience.

raphaelDkhn
raphaelDkhn approved these changes Oct 26, 2023
View reviewed changes
Copy link
Collaborator

@raphaelDkhn raphaelDkhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good first PR @TsBauer 👌

@raphaelDkhn
Copy link
Collaborator

@all-contributors add @TsBauer for code

@allcontributors allcontributors bot mentioned this pull request Oct 26, 2023
Merged
@allcontributors
Copy link
Contributor

@raphaelDkhn

I've put up a pull request to add @TsBauer! 🎉

@raphaelDkhn raphaelDkhn merged commit 5eafa4d into gizatechxyz:develop Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raphaelDkhn raphaelDkhn raphaelDkhn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TsBauer @raphaelDkhn