Add Bool Tensor Type #412
Closed
Add Bool Tensor Type #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ephraim-nonso
force-pushed
the
tensor_bool
branch
from
31280c3 to
4d2a52a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
Please check the type of change your PR introduces:
What is the current behavior?
I have added the Bool Tensor type implementation and the test for a 1-D tensor with the "at" operator.
Issue Number: 406
What is the new behavior?
Does this introduce a breaking change?
The implementation of the Bool Tensor would help me create the NOT operator which requires that the tensor inputs should be a bool type as well as the output tensor type constraints.
Other information
I'm currently testing the implementation but I am unable to detect when the test run for the Bool Type I created. I'm open to and corrections.