feat: deform conv 2D #586
Merged
feat: deform conv 2D #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@chachaleo does this code compiled on your side? I have a lot of compilation errors and unused variable warnings |
chachaleo
force-pushed
the
feat/DeformConv
branch
from
242f768 to
5d3802a
Compare
|
I fixed it but I will have to make other changes when the pr : refactor nn: helpers and enum is merged |
raphaelDkhn
approved these changes
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request type
What is the current behavior?
Issue Number: #298
What is the new behavior?
I've only implemented the 2D version so far, I'm a bit stuck on the 3D and ND part, I will give it another try but it might take more time.