materialDatabase updates #660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Switched tonemapper from ACES to AgX - Added iridescence for materials that support it - Changed reference image source to URL from API
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
example/materialDatabase.js
Outdated
| @@ -181,14 +181,23 @@ | |||
| material.roughness = 1.0; | |||
| material.ior = 1.5; | |||
| material.thickness = 1.0; | |||
| material.iridescence = 0.0; | |||
| material.iridescenceIOR = 1.0; | |||
| material.iridescenceThicknessRange = [ 0, 0 ] | |||
Check notice
Code scanning / CodeQL
Semicolon insertion Note
|
Amazing, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched tonemapper from ACES to AgX
Since the reference images use the AgX tonemapper (with the Base Contrast look), this update makes the render match the reference images better.
Before (ACES)
After (AgX)
Added iridescence for materials that support it
Materials such as Pearl and Soap Bubble now have values for iridescence on the API side and this change enables it whenever a thinFilmThickness value is found on a material.
Changed reference image source
The API provides a reference field with a URL to a reference image (same images as before) and is made for just this kind of application. In v2 of the API there will also be different sizes and file types available.