fix(matomo): add simple heuristic to choose smtp encryption mode #594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosmoz
force-pushed
the
kosmoz/fix-matomo-smtp-encryption-mode
branch
from
fb04cbe to
a29d80b
Compare
kosmoz
force-pushed
the
kosmoz/fix-matomo-smtp-encryption-mode
branch
from
a29d80b to
94c096d
Compare
christophenne
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SMTP port 465 is typically used with SSL/TLS, not STARTTLS. In this case Matomo must be configured with encryption mode SSL rather than TLS.
With this PR, the operator implicitly assumes that SSL should be used if the port is 465 or 2465 has been specified.
This is a bit of a hack, but I think it should work for most cases and at least it doesn't bring a breaking change.